Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing NOTE_* constants to apple #3883

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Add missing NOTE_* constants to apple #3883

merged 1 commit into from
Aug 29, 2024

Conversation

byteallen
Copy link
Contributor

@rustbot
Copy link
Collaborator

rustbot commented Aug 29, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

tgross35
tgross35 approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tgross35
Copy link
Contributor

Actually this needs the demver test, can you add these to libc-test/semver/apple.txt?

@tgross35
Copy link
Contributor

LGTM, please squash and I'll merge

@byteallen
Copy link
Contributor Author

Thanks

@byteallen
Copy link
Contributor Author

The commits have been squashed and pushed.

@tgross35
Copy link
Contributor

Thanks!

@tgross35
Copy link
Contributor

@rustbot label +stable-nominated

@rustbot rustbot added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Aug 29, 2024
@tgross35 tgross35 added this pull request to the merge queue Aug 29, 2024
Merged via the queue into rust-lang:main with commit 5c8a32d Aug 29, 2024
41 checks passed
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Aug 29, 2024
@byteallen @tgross35
Add missing NOTE_MACHTIME and NOTE_MACH_CONTINUOUS_TIME constants to …
ff9b210 
…apple.

(backport <rust-lang#3883>)
(cherry picked from commit b693854)
@tgross35 tgross35 mentioned this pull request Aug 29, 2024
Merged
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross35 tgross35 tgross35 approved these changes

Assignees

@JohnTitor JohnTitor

Labels
S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@byteallen @rustbot @tgross35 @JohnTitor