Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some constants and structs which were wrong for ESP-IDF targets. I created an app that compares all the constants in
src/unix/newlib
andsrc/unix/newlib/espidf
modules with the ones in ESP-IDF source code (accessed viaesp_idf_svc::sys
). Here is the app https:/SergioGasquez/libc-checks, using[email protected]
yields the following errors:All those errors are fixed in this PR, if I point the app to use the branch of this PR, no errors appear.
cc and thanks to @ivmarkov!
closes #3774