Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: emscripten: Use the latest emsdk 3.1.68 #3962

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kleisauke
Copy link
Contributor

And make the changes in commit 63b0d67 unconditional.

Supersedes: #3569.
Cherry-picks a couple of changes from: #3307.
Depends on: rust-lang/rust#131533.

(untested, so opened as a draft)

And make the changes in commit 63b0d67 unconditional.

Supersedes: rust-lang#3569.
Cherry-picks a couple of changes from: rust-lang#3307.
Depends on: rust-lang/rust#131533.
@rustbot
Copy link
Collaborator

rustbot commented Oct 11, 2024

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@hoodmane
Copy link

Thanks @kleisauke it would be nice to see time_t finally get fixed...

@juntyr
Copy link

juntyr commented Oct 11, 2024

Could/should this PR keep the emcc version check to give a nice error at build time if a now-no-longer supported Emscripten is used?

@hoodmane
Copy link

I wouldn't want rust to generate an error when building with Emscripten 3.1.58 since that is the version that Pyodide is using with Python 3.12 and it would prevent us from upgrading. Though I suppose that it would just require us to use a patched rust/libc and we are already doing that, it would be nice to avoid additional patches.

@hoodmane
Copy link

But having a version check would be fine as long as there is an override.

@juntyr
Copy link

juntyr commented Oct 11, 2024

I was thinking about the previous check for 3.1.42 when the ABI change happened, which previous libc versions still supported (now there would be an ABI break in the opposite direction).

I definitely agree that other than that pretty much any emcc version has to be allowed since there is no current indicator which versions are ABI compatible and which aren’t

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants