-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "For Implementers" In Documentation For Log::flush()
#522
Comments
AldaronLau
changed the title
Add "For Implementers" For
Add "For Implementers" In Documentation For Jul 30, 2022
log::flush()
Log::flush()
Thanks for the suggestion @AldaronLau! This sounds like a nice clarification to me. |
EFanZh
pushed a commit
to EFanZh/log
that referenced
this issue
Jul 23, 2023
Resolved rust-lang#522 * Add dep tracing v0.1.37 to binstalk * Use `tracing` instead of `log` for logging in binstalk * Rm dev dep `env_logger` since `log` is no longer used * Rm unused dep `log` from binstalk * Replace use of `log` with `tracing` in crates/bin * Enable feat std of dep log in crates/bin * Add dep tracing v0.1.37 to binstalk-downloader * Replace use of `log` with `tracing` in binstalk-downloader * Rm unused dep `log` from binstalk-downlaoder * Wrap `ops::{install, resolve}` in `tracing::instrument` * Wrap `Download::and_{extract, visit_tar}` in `instrument` Signed-off-by: Jiahao XU <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There is almost no information / clarity on what
flush()
should do and if it's called by any of the macros in this crate. I think it should say something like:This method isn’t called automatically by the
log!
macros. It can be called manually at shutdown.The text was updated successfully, but these errors were encountered: