Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

another test for too big type #2039

Merged
merged 1 commit into from
Mar 26, 2022
Merged

another test for too big type #2039

merged 1 commit into from
Mar 26, 2022

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Mar 26, 2022

The existing test covers "slice is bigger than largest supported object" but we had no test covering "total size is bigger than largest supported object", which happens when the unsized tail itself is okay in terms of size, but together with the sized prefix it becomes too big.

Cc rust-lang/rust#95334

@RalfJung
Copy link
Member Author

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 26, 2022

📌 Commit 3f8c3b7 has been approved by RalfJung

bors added a commit that referenced this pull request Mar 26, 2022
another test for too big type

The existing test covers "slice is bigger than largest supported object" but we had no test covering "total size is bigger than largest supported object", which happens when the unsized tail itself is okay in terms of size, but together with the sized prefix it becomes too big.

Cc rust-lang/rust#95334
@bors
Copy link
Collaborator

bors commented Mar 26, 2022

⌛ Testing commit 3f8c3b7 with merge b22707b...

@bors
Copy link
Collaborator

bors commented Mar 26, 2022

💔 Test failed - checks-actions

@RalfJung
Copy link
Member Author

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 26, 2022

📌 Commit 9772c85 has been approved by RalfJung

@bors
Copy link
Collaborator

bors commented Mar 26, 2022

⌛ Testing commit 9772c85 with merge 017b0fb...

@bors
Copy link
Collaborator

bors commented Mar 26, 2022

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 017b0fb to master...

@bors bors merged commit 017b0fb into rust-lang:master Mar 26, 2022
@RalfJung RalfJung deleted the too-big branch March 26, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants