Implement special swizzles for masks and remove {to,from}_bitmask_vector
#423
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bitmask vectors are a bit of a compromise, to allow bitmasks to be useful on vectors with length >64. They are wasteful, since they are
Simd<u8, N>
, 8x bigger than they need to be in order to work well with generics.Additionally, in #422, I'm finding that bitmask vector codegen doesn't work for non-powers-of-two, and even with a workaround, seems to have incorrect codegen on a handful of architectures.
In this PR I add an
extract
swizzle, and implement all of the special swizzles for masks, which I believe allows us to remove bitmask vectors. With a hypothetical 128-element vector, you could do: