Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linked list cursor names #2847

Merged
merged 4 commits into from
Jan 14, 2020
Merged

Fix linked list cursor names #2847

merged 4 commits into from
Jan 14, 2020

Commits on Jan 11, 2020

  1. Convert tabs to space in RFC 2570 Linked List Cursors

    Tabs render as 8 spaces on GitHub which is different from the
    standard Rust style (4 spaces).
    LukasKalbertodt committed Jan 11, 2020
    Configuration menu
    Copy the full SHA
    498c10a View commit details
    Browse the repository at this point in the history
  2. Rename some methods of Linked List Cursor

    These changes is where everyone seems to agree on.
    
    - peek -> peek_next
    - peek_before -> peek_prev
    - insert -> insert_after
    - insert_list -> splice_after
    - insert_list_before -> splice_before
    - split -> split_after
    LukasKalbertodt committed Jan 11, 2020
    Configuration menu
    Copy the full SHA
    b486793 View commit details
    Browse the repository at this point in the history
  3. Replace pop and pop_before with remove_current in Linked List C…

    …usors
    
    The name "pop" was critized in the discussion thread but despite agreement
    it should be changed, no one did. This commit implements basically the
    suggestion by Amanieu (but `remove_current` instead of `remove`). There is
    some discussion however, over if there should be two methods (differing in
    what element is the current one after deletion). This should be discussed
    in the tracking issue before stabilizing the feature.
    LukasKalbertodt committed Jan 11, 2020
    Configuration menu
    Copy the full SHA
    41a81ea View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2020

  1. Rename a few more methods in Linked List Cursor RFC

    These are just the names of the initially implementation.
    LukasKalbertodt committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    772fb67 View commit details
    Browse the repository at this point in the history