This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 257
Panic when editing file with any error in vs code #699
Labels
Comments
Minimal test case:
This seems to rely on the field init shorthand, and when there is an error there it causes the compiler to crash while trying to emit the save-analysis data. |
nrc
added a commit
to nrc/rust
that referenced
this issue
Feb 4, 2018
When looking up a field defintion, since the name might be incorrect in the field init shorthand case. cc rust-lang/rls#699
Fixed in rust-lang/rust#48007 |
Oh, it’s related to the specific error of the field name in the initializer? Could have sworn I tried a dozen different types of error and it felt it happened all the time, so I must have forgotten the “xs” error in the initializer when I tried those other errors. |
kennytm
added a commit
to kennytm/rust
that referenced
this issue
Feb 5, 2018
save-analysis: avoid implicit unwrap When looking up a field defintion, since the name might be incorrect in the field init shorthand case. cc rust-lang/rls#699 r? @eddyb
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In vs code on windows (1.19.2, ia32), rls seems to crash rustc as soon as there is an error in the edited file.
The vs code output window shows this backtrace. As long as the file is OK, there is no error logged and RLS seems to work, at least sporadically. Even when the error occurs, RLS often still appears to work (error squiggles appear, navigation seems to work). It's a bit hit & miss, and sometimes it just stops working for no apparent reason (single very simple .rs file cargo project). I can't reproduce the conditionsn that makes it stop working so I'm suspecting the error is somehow related.
After the first time this backtrace is shown, subsequent errors will instead have this trace:
The directory mentioned in the backtrace (~.multirust\toolchains\stable) does indeed not exist.
The text was updated successfully, but these errors were encountered: