False positive assertions_on_constants

[MikailBag]

https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=40fdbfbe2885aeb26531533ee38b450f

While expression can be compile-time evaluated to true, it can make sense to be sure that Foo will always be smaller that Bar.

[JohnTitor]

Uhm, I feel this isn't false positive, but expected behavior. The more appropriate approach is to use panic!(), unreachable!(), or similar functions/macros.

[flip1995]

It is expected behavior, how the lint is currently written. A possible change would be to allow comparisons in asserts (only <,<=,>=,>, for the rest there is *_eq/*_ne). We could then add a pedantic lint, that also triggers on comparisons, since this is still a useful lint.

The question now is: Is the lint still useful once comparisons are not linted? Because then it pretty much only lints on literal true/false.

[ghost]

Maybe continue to lint in the false case but allow the true one since it's useful for documenting assumptions.

[flip1995]

Duplicate of #8159 , which has some more details.