update the tracking issue for structural match violations

and bless a test I missed
rust-lang · Jan 27, 2024 · 0808691 · 0808691
1 parent 32e4862
commit 0808691
Show file tree

Hide file tree

Showing 16 changed files with 89 additions and 72 deletions.
diff --git a/compiler/rustc_lint_defs/src/builtin.rs b/compiler/rustc_lint_defs/src/builtin.rs
@@ -2333,7 +2333,7 @@ declare_lint! {
  "constant used in pattern contains value of non-structural-match type in a field or a variant",
  @future_incompatible = FutureIncompatibleInfo {
  reason: FutureIncompatibilityReason::FutureReleaseErrorReportInDeps,
- reference: "issue #62411 <https:/rust-lang/rust/issues/62411>",
+ reference: "issue #120362 <https:/rust-lang/rust/issues/120362>",
  };
 }
 
@@ -2389,7 +2389,7 @@ declare_lint! {
  "pointers are not structural-match",
  @future_incompatible = FutureIncompatibleInfo {
  reason: FutureIncompatibilityReason::FutureReleaseErrorReportInDeps,
- reference: "issue #62411 <https:/rust-lang/rust/issues/70861>",
+ reference: "issue #120362 <https:/rust-lang/rust/issues/120362>",
  };
 }
 

diff --git a/tests/ui/closures/2229_closure_analysis/match/match-edge-cases_1.stderr b/tests/ui/closures/2229_closure_analysis/match/match-edge-cases_1.stderr
@@ -5,7 +5,7 @@ LL | NUMBER_POINTER => (),
  | ^^^^^^^^^^^^^^
  |
  = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
- = note: for more information, see issue #62411 <https:/rust-lang/rust/issues/70861>
+ = note: for more information, see issue #120362 <https:/rust-lang/rust/issues/120362>
  = note: `#[warn(pointer_structural_match)]` on by default
 
 warning: 1 warning emitted
@@ -18,6 +18,6 @@ LL | NUMBER_POINTER => (),
  | ^^^^^^^^^^^^^^
  |
  = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
- = note: for more information, see issue #62411 <https:/rust-lang/rust/issues/70861>
+ = note: for more information, see issue #120362 <https:/rust-lang/rust/issues/120362>
  = note: `#[warn(pointer_structural_match)]` on by default
 
diff --git a/tests/ui/consts/const_in_pattern/issue-34784-match-on-non-int-raw-ptr.stderr b/tests/ui/consts/const_in_pattern/issue-34784-match-on-non-int-raw-ptr.stderr
@@ -5,7 +5,7 @@ LL | C => {}
  | ^
  |
  = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
- = note: for more information, see issue #62411 <https:/rust-lang/rust/issues/70861>
+ = note: for more information, see issue #120362 <https:/rust-lang/rust/issues/120362>
 note: the lint level is defined here
  --> $DIR/issue-34784-match-on-non-int-raw-ptr.rs:1:9
  |
@@ -19,7 +19,7 @@ LL | C_INNER => {}
  | ^^^^^^^
  |
  = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
- = note: for more information, see issue #62411 <https:/rust-lang/rust/issues/70861>
+ = note: for more information, see issue #120362 <https:/rust-lang/rust/issues/120362>
 
 error: function pointers and raw pointers not derived from integers in patterns behave unpredictably and should not be relied upon. See https:/rust-lang/rust/issues/70861 for details.
  --> $DIR/issue-34784-match-on-non-int-raw-ptr.rs:30:9
@@ -28,7 +28,7 @@ LL | D => {}
  | ^
  |
  = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
- = note: for more information, see issue #62411 <https:/rust-lang/rust/issues/70861>
+ = note: for more information, see issue #120362 <https:/rust-lang/rust/issues/120362>
 
 error: function pointers and raw pointers not derived from integers in patterns behave unpredictably and should not be relied upon. See https:/rust-lang/rust/issues/70861 for details.
  --> $DIR/issue-34784-match-on-non-int-raw-ptr.rs:36:9
@@ -37,7 +37,7 @@ LL | STR => {}
  | ^^^
  |
  = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
- = note: for more information, see issue #62411 <https:/rust-lang/rust/issues/70861>
+ = note: for more information, see issue #120362 <https:/rust-lang/rust/issues/120362>
 
 error: aborting due to 4 previous errors
 
@@ -49,7 +49,7 @@ LL | C => {}
  | ^
  |
  = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
- = note: for more information, see issue #62411 <https:/rust-lang/rust/issues/70861>
+ = note: for more information, see issue #120362 <https:/rust-lang/rust/issues/120362>
 note: the lint level is defined here
  --> $DIR/issue-34784-match-on-non-int-raw-ptr.rs:1:9
  |
@@ -64,7 +64,7 @@ LL | C_INNER => {}
  | ^^^^^^^
  |
  = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
- = note: for more information, see issue #62411 <https:/rust-lang/rust/issues/70861>
+ = note: for more information, see issue #120362 <https:/rust-lang/rust/issues/120362>
 note: the lint level is defined here
  --> $DIR/issue-34784-match-on-non-int-raw-ptr.rs:1:9
  |
@@ -79,7 +79,7 @@ LL | D => {}
  | ^
  |
  = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
- = note: for more information, see issue #62411 <https:/rust-lang/rust/issues/70861>
+ = note: for more information, see issue #120362 <https:/rust-lang/rust/issues/120362>
 note: the lint level is defined here
  --> $DIR/issue-34784-match-on-non-int-raw-ptr.rs:1:9
  |
@@ -94,7 +94,7 @@ LL | STR => {}
  | ^^^
  |
  = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
- = note: for more information, see issue #62411 <https:/rust-lang/rust/issues/70861>
+ = note: for more information, see issue #120362 <https:/rust-lang/rust/issues/120362>
 note: the lint level is defined here
  --> $DIR/issue-34784-match-on-non-int-raw-ptr.rs:1:9
  |

diff --git a/tests/ui/consts/const_in_pattern/issue-44333.stderr b/tests/ui/consts/const_in_pattern/issue-44333.stderr
@@ -5,7 +5,7 @@ LL | FOO => println!("foo"),
  | ^^^
  |
  = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
- = note: for more information, see issue #62411 <https:/rust-lang/rust/issues/70861>
+ = note: for more information, see issue #120362 <https:/rust-lang/rust/issues/120362>
 note: the lint level is defined here
  --> $DIR/issue-44333.rs:3:9
  |
@@ -19,7 +19,7 @@ LL | BAR => println!("bar"),
  | ^^^
  |
  = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
- = note: for more information, see issue #62411 <https:/rust-lang/rust/issues/70861>
+ = note: for more information, see issue #120362 <https:/rust-lang/rust/issues/120362>
 
 warning: 2 warnings emitted
 
@@ -31,7 +31,7 @@ LL | FOO => println!("foo"),
  | ^^^
  |
  = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
- = note: for more information, see issue #62411 <https:/rust-lang/rust/issues/70861>
+ = note: for more information, see issue #120362 <https:/rust-lang/rust/issues/120362>
 note: the lint level is defined here
  --> $DIR/issue-44333.rs:3:9
  |
@@ -46,7 +46,7 @@ LL | BAR => println!("bar"),
  | ^^^
  |
  = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
- = note: for more information, see issue #62411 <https:/rust-lang/rust/issues/70861>
+ = note: for more information, see issue #120362 <https:/rust-lang/rust/issues/120362>
 note: the lint level is defined here
  --> $DIR/issue-44333.rs:3:9
  |

diff --git a/tests/ui/consts/const_in_pattern/reject_non_structural.rs b/tests/ui/consts/const_in_pattern/reject_non_structural.rs
@@ -100,5 +100,5 @@ fn main() {
  //~| NOTE the traits must be derived
  //~| NOTE StructuralPartialEq.html for details
  //~| WARN previously accepted by the compiler but is being phased out
- //~| NOTE for more information, see issue #62411
+ //~| NOTE for more information, see
 }
diff --git a/tests/ui/consts/const_in_pattern/reject_non_structural.stderr b/tests/ui/consts/const_in_pattern/reject_non_structural.stderr
@@ -86,7 +86,7 @@ LL | match &Some(NoDerive) { ADDR_OF => dbg!(ADDR_OF), _ => panic!("whoops")
  | ^^^^^^^
  |
  = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
- = note: for more information, see issue #62411 <https:/rust-lang/rust/issues/62411>
+ = note: for more information, see issue #120362 <https:/rust-lang/rust/issues/120362>
  = note: the traits must be derived, manual `impl`s are not sufficient
  = note: see https://doc.rust-lang.org/stable/std/marker/trait.StructuralPartialEq.html for details
 note: the lint level is defined here
@@ -105,7 +105,7 @@ LL | match &Some(NoDerive) { ADDR_OF => dbg!(ADDR_OF), _ => panic!("whoops")
  | ^^^^^^^
  |
  = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
- = note: for more information, see issue #62411 <https:/rust-lang/rust/issues/62411>
+ = note: for more information, see issue #120362 <https:/rust-lang/rust/issues/120362>
  = note: the traits must be derived, manual `impl`s are not sufficient
  = note: see https://doc.rust-lang.org/stable/std/marker/trait.StructuralPartialEq.html for details
 note: the lint level is defined here

diff --git a/tests/ui/consts/issue-89088.stderr b/tests/ui/consts/issue-89088.stderr
@@ -0,0 +1,17 @@
+Future incompatibility report: Future breakage diagnostic:
+warning: to use a constant of type `Cow<'_, str>` in a pattern, `Cow<'_, str>` must be annotated with `#[derive(PartialEq)]`
+ --> $DIR/issue-89088.rs:19:9
+ |
+LL | FOO => todo!(),
+ | ^^^
+ |
+ = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
+ = note: for more information, see issue #120362 <https:/rust-lang/rust/issues/120362>
+ = note: the traits must be derived, manual `impl`s are not sufficient
+ = note: see https://doc.rust-lang.org/stable/std/marker/trait.StructuralPartialEq.html for details
+note: the lint level is defined here
+ --> $DIR/issue-89088.rs:5:10
+ |
+LL | #![allow(indirect_structural_match)]
+ | ^^^^^^^^^^^^^^^^^^^^^^^^^
+
diff --git a/tests/ui/pattern/usefulness/const-partial_eq-fallback-ice.stderr b/tests/ui/pattern/usefulness/const-partial_eq-fallback-ice.stderr
@@ -17,7 +17,7 @@ LL | if let CONSTANT = &&MyType {
  | ^^^^^^^^
  |
  = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
- = note: for more information, see issue #62411 <https:/rust-lang/rust/issues/62411>
+ = note: for more information, see issue #120362 <https:/rust-lang/rust/issues/120362>
  = note: the traits must be derived, manual `impl`s are not sufficient
  = note: see https://doc.rust-lang.org/stable/std/marker/trait.StructuralPartialEq.html for details
 note: the lint level is defined here

diff --git a/tests/ui/pattern/usefulness/consts-opaque.stderr b/tests/ui/pattern/usefulness/consts-opaque.stderr
@@ -5,7 +5,7 @@ LL | QUUX => {}
  | ^^^^
  |
  = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
- = note: for more information, see issue #62411 <https:/rust-lang/rust/issues/70861>
+ = note: for more information, see issue #120362 <https:/rust-lang/rust/issues/120362>
  = note: `#[warn(pointer_structural_match)]` on by default
 
 warning: function pointers and raw pointers not derived from integers in patterns behave unpredictably and should not be relied upon. See https:/rust-lang/rust/issues/70861 for details.
@@ -15,7 +15,7 @@ LL | QUUX => {}
  | ^^^^
  |
  = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
- = note: for more information, see issue #62411 <https:/rust-lang/rust/issues/70861>
+ = note: for more information, see issue #120362 <https:/rust-lang/rust/issues/120362>
 
 warning: function pointers and raw pointers not derived from integers in patterns behave unpredictably and should not be relied upon. See https:/rust-lang/rust/issues/70861 for details.
  --> $DIR/consts-opaque.rs:108:9
@@ -24,7 +24,7 @@ LL | WRAPQUUX => {}
  | ^^^^^^^^
  |
  = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
- = note: for more information, see issue #62411 <https:/rust-lang/rust/issues/70861>
+ = note: for more information, see issue #120362 <https:/rust-lang/rust/issues/120362>
 
 warning: function pointers and raw pointers not derived from integers in patterns behave unpredictably and should not be relied upon. See https:/rust-lang/rust/issues/70861 for details.
  --> $DIR/consts-opaque.rs:110:9
@@ -33,7 +33,7 @@ LL | WRAPQUUX => {}
  | ^^^^^^^^
  |
  = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
- = note: for more information, see issue #62411 <https:/rust-lang/rust/issues/70861>
+ = note: for more information, see issue #120362 <https:/rust-lang/rust/issues/120362>
 
 warning: function pointers and raw pointers not derived from integers in patterns behave unpredictably and should not be relied upon. See https:/rust-lang/rust/issues/70861 for details.
  --> $DIR/consts-opaque.rs:117:9
@@ -42,7 +42,7 @@ LL | WRAPQUUX => {}
  | ^^^^^^^^
  |
  = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
- = note: for more information, see issue #62411 <https:/rust-lang/rust/issues/70861>
+ = note: for more information, see issue #120362 <https:/rust-lang/rust/issues/120362>
 
 warning: function pointers and raw pointers not derived from integers in patterns behave unpredictably and should not be relied upon. See https:/rust-lang/rust/issues/70861 for details.
  --> $DIR/consts-opaque.rs:127:9
@@ -51,7 +51,7 @@ LL | WRAPQUUX => {}
  | ^^^^^^^^
  |
  = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
- = note: for more information, see issue #62411 <https:/rust-lang/rust/issues/70861>
+ = note: for more information, see issue #120362 <https:/rust-lang/rust/issues/120362>
 
 warning: function pointers and raw pointers not derived from integers in patterns behave unpredictably and should not be relied upon. See https:/rust-lang/rust/issues/70861 for details.
  --> $DIR/consts-opaque.rs:139:9
@@ -60,7 +60,7 @@ LL | WHOKNOWSQUUX => {}
  | ^^^^^^^^^^^^
  |
  = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
- = note: for more information, see issue #62411 <https:/rust-lang/rust/issues/70861>
+ = note: for more information, see issue #120362 <https:/rust-lang/rust/issues/120362>
 
 warning: function pointers and raw pointers not derived from integers in patterns behave unpredictably and should not be relied upon. See https:/rust-lang/rust/issues/70861 for details.
  --> $DIR/consts-opaque.rs:142:9
@@ -69,7 +69,7 @@ LL | WHOKNOWSQUUX => {}
  | ^^^^^^^^^^^^
  |
  = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
- = note: for more information, see issue #62411 <https:/rust-lang/rust/issues/70861>
+ = note: for more information, see issue #120362 <https:/rust-lang/rust/issues/120362>
 
 error: unreachable pattern
  --> $DIR/consts-opaque.rs:48:9
@@ -174,7 +174,7 @@ LL | QUUX => {}
  | ^^^^
  |
  = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
- = note: for more information, see issue #62411 <https:/rust-lang/rust/issues/70861>
+ = note: for more information, see issue #120362 <https:/rust-lang/rust/issues/120362>
  = note: `#[warn(pointer_structural_match)]` on by default
 
 Future breakage diagnostic:
@@ -185,7 +185,7 @@ LL | QUUX => {}
  | ^^^^
  |
  = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
- = note: for more information, see issue #62411 <https:/rust-lang/rust/issues/70861>
+ = note: for more information, see issue #120362 <https:/rust-lang/rust/issues/120362>
  = note: `#[warn(pointer_structural_match)]` on by default
 
 Future breakage diagnostic:
@@ -196,7 +196,7 @@ LL | WRAPQUUX => {}
  | ^^^^^^^^
  |
  = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
- = note: for more information, see issue #62411 <https:/rust-lang/rust/issues/70861>
+ = note: for more information, see issue #120362 <https:/rust-lang/rust/issues/120362>
  = note: `#[warn(pointer_structural_match)]` on by default
 
 Future breakage diagnostic:
@@ -207,7 +207,7 @@ LL | WRAPQUUX => {}
  | ^^^^^^^^
  |
  = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
- = note: for more information, see issue #62411 <https:/rust-lang/rust/issues/70861>
+ = note: for more information, see issue #120362 <https:/rust-lang/rust/issues/120362>
  = note: `#[warn(pointer_structural_match)]` on by default
 
 Future breakage diagnostic:
@@ -218,7 +218,7 @@ LL | WRAPQUUX => {}
  | ^^^^^^^^
  |
  = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
- = note: for more information, see issue #62411 <https:/rust-lang/rust/issues/70861>
+ = note: for more information, see issue #120362 <https:/rust-lang/rust/issues/120362>
  = note: `#[warn(pointer_structural_match)]` on by default
 
 Future breakage diagnostic:
@@ -229,7 +229,7 @@ LL | WRAPQUUX => {}
  | ^^^^^^^^
  |
  = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
- = note: for more information, see issue #62411 <https:/rust-lang/rust/issues/70861>
+ = note: for more information, see issue #120362 <https:/rust-lang/rust/issues/120362>
  = note: `#[warn(pointer_structural_match)]` on by default
 
 Future breakage diagnostic:
@@ -240,7 +240,7 @@ LL | WHOKNOWSQUUX => {}
  | ^^^^^^^^^^^^
  |
  = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
- = note: for more information, see issue #62411 <https:/rust-lang/rust/issues/70861>
+ = note: for more information, see issue #120362 <https:/rust-lang/rust/issues/120362>
  = note: `#[warn(pointer_structural_match)]` on by default
 
 Future breakage diagnostic:
@@ -251,6 +251,6 @@ LL | WHOKNOWSQUUX => {}
  | ^^^^^^^^^^^^
  |
  = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
- = note: for more information, see issue #62411 <https:/rust-lang/rust/issues/70861>
+ = note: for more information, see issue #120362 <https:/rust-lang/rust/issues/120362>
  = note: `#[warn(pointer_structural_match)]` on by default