Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Rename "good path delayed bugs" as "weak delayed bugs".
Because they're like delayed bugs, but weaker, e.g. they don't provide an `ErrorGuaranteed`. This lets us remove of some old FIXME comments complaining about the "good path" name. The commit also splits `Level::DelayedBug` into two parts rather than using a parameter. The two kinds of delayed bug have quite different semantics so a stronger conceptual separation is nice. Plus it moves the `DelayedBug` variant after `Error` in `Level`, to reflect the fact that it's weaker than `Error` -- it might trigger an error but also might not. Plus it condenses some of the comments on `Level` into a table, for easier reading, and introduces `can_be_top_or_sub` to indicate which levels can be used in top-level diagnostics vs. subdiagnostics. Things renamed: - `DiagCtxtInner::good_path_delayed_bugs` -> `DiagCtxtInner::weak_delayed_bugs` - `DiagCtxtInner::span_delayed_bugs` -> `DiagCtxtInner::delayed_bugs` - `DelayedBugKind::GoodPath` -> `DelayedBugKind::Weak`
- Loading branch information