Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The symlinks_works test is ignored on windows #10264

Closed
alexcrichton opened this issue Nov 4, 2013 · 3 comments
Closed

The symlinks_works test is ignored on windows #10264

alexcrichton opened this issue Nov 4, 2013 · 3 comments
Labels
O-windows Operating system: Windows

Comments

@alexcrichton
Copy link
Member

In #10179 I added support for symlinks bindings to libuv. I could never get the symlinks_work, so I'm ignoring it for now to get this patch landed.

This warrants further investigation, the problem I kept seeing was that a condition was raised saying "operation not permitted".
@klutzy
Copy link
Contributor

klutzy commented May 28, 2014

Both libuv and libnative call CreateSymbolicLink API, which fails if user doesn't have some permission on the directories. (GetLastError() returns ERROR_PRIVILEGE_NOT_HELD on my machine)
Let's ignore the tests and add some notes on symlink document!

@klutzy klutzy mentioned this issue May 28, 2014
Closed
@steveklabnik
Copy link
Member

libuv is totally gone now, so as far as I can tell, this needs closed.

@klutzy
Copy link
Contributor

klutzy commented Apr 16, 2015

@steveklabnik the test is still at libstd/fs.rs. Could you reopen this?

Jarcho pushed a commit to Jarcho/rust that referenced this issue Feb 26, 2023
@bors
Auto merge of rust-lang#10391 - ldm0:ldm0_fix_unwrap_in_tests, r=xFre…
b528cc9 
…dnet

Fix test function checker in `unwrap_used`, `expect_used`

After rust-lang#9686 , `unwrap` and `expect` in integration tests and raw test functions won't be allowed.

fixes rust-lang#10011
fixes rust-lang#10238
fixes rust-lang#10264

---

changelog: Fix: [`expect_used`], [`unwrap_used`], [`dbg_macro`], [`print_stdout`], [`print_stderr`]: No longer lint in test functions, if the related configuration is set
[rust-lang#10391](rust-lang/rust-clippy#10391)
<!-- changelog_checked -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
O-windows Operating system: Windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@steveklabnik @alexcrichton @huonw @klutzy