Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiletest: don't silently accept unsupported directives in test suites #128058

Open
jieyouxu opened this issue Jul 22, 2024 · 0 comments
Open

compiletest: don't silently accept unsupported directives in test suites #128058

jieyouxu opened this issue Jul 22, 2024 · 0 comments
Labels
A-compiletest Area: The compiletest test runner A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@jieyouxu
Copy link
Member

Yes, there are special handling here and there for specific directives. But the handling is limited and is only for specific directives in specific test suites.

We should error if a test writer specifies a directive invalid for a given test suite.

This may require reworking how directives are handled, i.e. have test suites "register" what directives they support.
@jieyouxu jieyouxu added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself A-compiletest Area: The compiletest test runner labels Jul 22, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jul 22, 2024
@jieyouxu jieyouxu removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jul 22, 2024
@jieyouxu jieyouxu changed the title compiletest: don't silently accept unsupported directives for each test suite compiletest: don't silently accept unsupported directives in test suites Jul 22, 2024
@jieyouxu jieyouxu mentioned this issue Jul 22, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-compiletest Area: The compiletest test runner A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
compiletest maintenance and improvements
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jieyouxu @rustbot