Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boxed strings don't work #2638

Closed
msullivan opened this issue Jun 18, 2012 · 2 comments
Closed

Boxed strings don't work #2638

msullivan opened this issue Jun 18, 2012 · 2 comments
Labels
A-codegen Area: Code generation I-crash Issue: The compiler crashes (SIGSEGV, SIGABRT, etc). Use I-ICE instead when the compiler panics.

Comments

@msullivan
Copy link
Contributor

str/@ is partially implemented, but trips LLVM errors when compiling.
@ghost ghost assigned msullivan Jun 18, 2012
@msullivan
Copy link
Contributor Author

Once that is fixed, they start getting leaked, since they get allocated in a wrong way.

@msullivan
Copy link
Contributor Author

And once that is fixed, the operations do the wrong thing...

msullivan added a commit that referenced this issue Jun 18, 2012
@msullivan
Put type descriptors in strings created by the runtime. Progress on #…
88ec259 
…2638.
@msullivan msullivan removed their assignment Jun 16, 2014
RalfJung pushed a commit to RalfJung/rust that referenced this issue Nov 6, 2022
@bors
Auto merge of rust-lang#2641 - DrMeepster:init_once_acquire, r=RalfJung
4492c02 
InitOnce: synchronize with completion when already complete

The completion of an InitOnce happens-before the threads waiting on it wake up. However, this is not the case for threads that call `InitOnceBeginInitialize` after the completion, leading to data races and outdated weak memory loads as observed in the CI for  rust-lang#2638. This PR fixes this.
RalfJung pushed a commit to RalfJung/rust that referenced this issue Nov 6, 2022
@bors
Auto merge of rust-lang#2638 - DrMeepster:windows-condvars, r=RalfJung
f60a2ae 
Implement condvars for Windows

Adds 3 shims for Windows: `SleepConditionVariableSRW`, `WakeConditionVariable`, `WakeAllConditionVariable` to add support for condvars (which fixes rust-lang#2628).

Salvaged from what was removed from rust-lang#2231
RalfJung pushed a commit to RalfJung/rust that referenced this issue Nov 15, 2022
@bors
Auto merge of rust-lang#2638 - DrMeepster:windows-condvars, r=RalfJung
4828edf 
Implement condvars for Windows

Adds 3 shims for Windows: `SleepConditionVariableSRW`, `WakeConditionVariable`, `WakeAllConditionVariable` to add support for condvars (which fixes rust-lang#2628).

Salvaged from what was removed from rust-lang#2231
Aaron1011 pushed a commit to Aaron1011/rust that referenced this issue Jan 6, 2023
@bors
Auto merge of rust-lang#2641 - DrMeepster:init_once_acquire, r=RalfJung
9568d7e 
InitOnce: synchronize with completion when already complete

The completion of an InitOnce happens-before the threads waiting on it wake up. However, this is not the case for threads that call `InitOnceBeginInitialize` after the completion, leading to data races and outdated weak memory loads as observed in the CI for  rust-lang#2638. This PR fixes this.
Aaron1011 pushed a commit to Aaron1011/rust that referenced this issue Jan 6, 2023
@bors
Auto merge of rust-lang#2638 - DrMeepster:windows-condvars, r=RalfJung
bf0f47b 
Implement condvars for Windows

Adds 3 shims for Windows: `SleepConditionVariableSRW`, `WakeConditionVariable`, `WakeAllConditionVariable` to add support for condvars (which fixes rust-lang#2628).

Salvaged from what was removed from rust-lang#2231
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-codegen Area: Code generation I-crash Issue: The compiler crashes (SIGSEGV, SIGABRT, etc). Use I-ICE instead when the compiler panics.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@msullivan