Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Valgrind tests fail when compiled dynamically #31968

Closed
alexcrichton opened this issue Feb 29, 2016 · 2 comments · Fixed by #64067
Closed

Valgrind tests fail when compiled dynamically #31968

alexcrichton opened this issue Feb 29, 2016 · 2 comments · Fixed by #64067
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@alexcrichton
Copy link
Member

Right now on our bots we're basically in a state where if valgrind rpass tests are compiled dynamically they will all fail, but when compiled statically they will pass. I'm not really sure what's going on unfortunately, but this is either a bug in valgrind or a bug with us, and we should know precisely what it is to ensure something more sinister isn't lurking.

Some links:
@alexcrichton alexcrichton mentioned this issue Feb 29, 2016
Merged
@nagisa
Copy link
Member

nagisa commented Mar 1, 2016

All the failures seem to be within platform’s dynamic loader. Here’s a few things to try:

  1. Does updating kernel+glibc to the most recent versions (4.4-ish and 2.23-ish, respectively) help?
  2. Does downgrading kernel+glibc to some older version help?
  3. Does non-linux/non-glibc work correctly?

@cyplo
Copy link
Contributor

cyplo commented Feb 22, 2017

Any news/changes on this one ?

@Mark-Simulacrum Mark-Simulacrum added the A-testsuite Area: The testsuite used to check the correctness of rustc label May 24, 2017
@Mark-Simulacrum Mark-Simulacrum added the C-bug Category: This is a bug. label Jul 24, 2017
@jonas-schievink jonas-schievink added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) and removed T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-build labels Apr 21, 2019
@Mark-Simulacrum Mark-Simulacrum mentioned this issue Sep 1, 2019
Merged
Centril added a commit to Centril/rust that referenced this issue Sep 5, 2019
@Centril
Rollup merge of rust-lang#64067 - Mark-Simulacrum:valgrind-dyn, r=ale…
8b83eb7 
…xcrichton

Remove no-prefer-dynamic from valgrind tests

This seems to be working locally.

Resolves rust-lang#31968
Centril added a commit to Centril/rust that referenced this issue Sep 6, 2019
@Centril
Rollup merge of rust-lang#64067 - Mark-Simulacrum:valgrind-dyn, r=ale…
72eca54 
…xcrichton

Remove no-prefer-dynamic from valgrind tests

This seems to be working locally.

Resolves rust-lang#31968
@bors bors closed this as completed in e618135 Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove no-prefer-dynamic from valgrind tests Mark-Simulacrum/rust
5 participants
@alexcrichton @cyplo @nagisa @jonas-schievink @Mark-Simulacrum