Tracking issue for reverting cargo check in Rust 1.15
#38666
Assignees
Labels
P-high
High priority
regression-from-stable-to-beta
Performance or correctness regression from stable to beta.
Comments
alexcrichton
added
P-high
|
I'm tagging this as a regression to make sure we don't lose track of it, but to be clear there's not actually a regression here. Just want to piggy back off the processes that triage beta regressions! |
alexcrichton
added a commit
to alexcrichton/cargo
that referenced
this issue
Dec 28, 2016
This commit removes the `cargo check` subcommand from the `rust-1.15.0` branch of Cargo. The rationale is explained in rust-lang/rust#38666, but the tl;dr; is that it's relatively buggy and not ready to ride the trains to stable. This commit takes as little an invasive as approach as possible by simply removing the `cargo check` command and associated tests. The backend remains with support for `cargo check`, but we shouldn't be exercising it in practice.
|
cc @nrc |
bors
added a commit
to rust-lang/cargo
that referenced
this issue
Dec 29, 2016
Remove the `cargo check` subcommand from Rust 1.15 This commit removes the `cargo check` subcommand from the `rust-1.15.0` branch of Cargo. The rationale is explained in rust-lang/rust#38666, but the tl;dr; is that it's relatively buggy and not ready to ride the trains to stable. This commit takes as little an invasive as approach as possible by simply removing the `cargo check` command and associated tests. The backend remains with support for `cargo check`, but we shouldn't be exercising it in practice.
|
Ok, this should be done now, so closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is a tracking issue for the tasks to revert
cargo checkand--crate-type=metadatain the Rust 1.15 release branch. currently--crate-type=metadatais on thebetabranch of this repository andcargo checkis itself in the rust-1.15.0 branch of the Cargo repository.Unfortunately there have been a number of bugs associated with
cargo checksince first implemented:cargo checkcompiles library object code if a binary exists cargo#3418cargo checkrecompiles dependencies when checking lib and bin separately cargo#3421cargo checkfails oddly on binaries cargo#3419All of these issues, however, should be fixed by these two changes:
We need to fix the issues on beta in one way or another, and today the tools team decided to go ahead and revert the changes on beta and let the bug fixes ride the trains to stable in the Rust 1.16 release. There's two things that need to happen to close out this issue:
--crate-type=metadatain the compiler - Remove --crate-type=metadata from beta #38668cargo checkcommand from Cargo - Remove thecargo checksubcommand from Rust 1.15 cargo#3465The text was updated successfully, but these errors were encountered: