Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NLL] issue-29844.rs test overflows while adding drop-check rules #47589

Closed
spastorino opened this issue Jan 19, 2018 · 2 comments
Closed

[NLL] issue-29844.rs test overflows while adding drop-check rules #47589

spastorino opened this issue Jan 19, 2018 · 2 comments
Assignees
@Aaron1011
Labels
A-NLL Area: Non-lexical lifetimes (NLL) I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Milestone
NLL: Valid code w...

Comments

@spastorino
Copy link
Member 

$ RUST_BACKTRACE=full rustc +stage1 src/test/run-pass/issue-29844.rs -Znll -Zborrowck=mir -Ztwo-phase-borrows
error[E0320]: overflow while adding drop-check rules for std::vec::Vec<AttachInfo<'_, Resources>>
  |
  = note: overflowed on DescriptorSet<'_>

error[E0320]: overflow while adding drop-check rules for std::vec::Vec<AttachInfo<'_, Resources>>
  |
  = note: overflowed on *const alloc::arc::ArcInner<DescriptorSet<'_>>

error[E0320]: overflow while adding drop-check rules for DescriptorSet<'_>
  |
  = note: overflowed on DescriptorSet<'_>

error[E0320]: overflow while adding drop-check rules for DescriptorSet<'_>
  |
  = note: overflowed on *const alloc::arc::ArcInner<DescriptorSet<'_>>

error: aborting due to 4 previous errors
@nikomatsakis nikomatsakis added A-NLL Area: Non-lexical lifetimes (NLL) WG-compiler-nll I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 19, 2018
@nikomatsakis nikomatsakis added this to the NLL: Valid code works milestone Jan 19, 2018
@Aaron1011
Copy link
Member

I'd like to work on this.

@Aaron1011
Copy link
Member

@nikomatsakis: This appears to be a regular error, not an ICE.

Aaron1011 added a commit to Aaron1011/rust that referenced this issue Feb 1, 2018
@Aaron1011
Fix overflow when performing drop check calculations in NLL
0fd4f37 
Clearing out the infcx's region constraints after processing each type
ends up interacting badly with normalizing associated types. This commit
keeps all region constraints intact until the end of
TypeLivenessGenerator.add_drop_live_constraint, ensuring that normalized
types are able to re-use existing inference variables.

Fixes rust-lang#47589
@Aaron1011 Aaron1011 mentioned this issue Feb 1, 2018
Merged
bors added a commit that referenced this issue Feb 5, 2018
@bors
Auto merge of #47920 - Aaron1011:nll-overflow, r=pnkfelix
b0a396b 
Fix overflow when performing drop check calculations in NLL

Clearing out the infcx's region constraints after processing each type
ends up interacting badly with normalizing associated types. This commit
keeps all region constraints intact until the end of
TypeLivenessGenerator.add_drop_live_constraint, ensuring that normalized
types are able to re-use existing inference variables.

Fixes #47589
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Aaron1011 Aaron1011

Labels
A-NLL Area: Non-lexical lifetimes (NLL) I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
NLL: Valid code works
Development

No branches or pull requests
3 participants
@spastorino @nikomatsakis @Aaron1011