Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No error handling of binary/hexadecimal floating literals #4804

Closed
lifthrasiir opened this issue Feb 5, 2013 · 1 comment
Closed

No error handling of binary/hexadecimal floating literals #4804

lifthrasiir opened this issue Feb 5, 2013 · 1 comment
Labels
A-parser Area: The parsing of Rust source code to an AST

Comments

@lifthrasiir
Copy link
Contributor

Due to the lack of checking (i.e. right before libsyntax/parse/lexer.rs:434), the current lexer parses 0x12.3 as a synonym to 12.3 (!). Moreover 0xAA.5 triggers an assertion failure from APFloat. Tangentially related to issue #1433.
@lifthrasiir lifthrasiir mentioned this issue Feb 6, 2013
Closed
bors added a commit that referenced this issue Feb 7, 2013
@bors
auto merge of #4816 : lifthrasiir/rust/float-literal, r=graydon
d9a61f2 
See #4804 for details.
@catamorphism
Copy link
Contributor

I'm going to assume that d9a61f2 fixes this, and close. Reopen if I'm wrong!

flip1995 pushed a commit to flip1995/rust that referenced this issue Jan 15, 2021
@bors
Auto merge of rust-lang#6571 - ThibsG:BoxedLocalTrait, r=phansch
ee0598e 
Fix FP for `boxed_local` lint in default trait fn impl

Fix FP on default trait function implementation on `boxed_local` lint.

Maybe I checked too much when looking if `self` is carrying `Self` in its bound type.
I can't find a good test case for this, so it could be too much conservative.
Let me know if you think only detecting `self` parameter is enough.

Fixes: rust-lang#4804

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-parser Area: The parsing of Rust source code to an AST
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lifthrasiir @catamorphism