Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete update-all-references script #50853

Closed
oli-obk opened this issue May 18, 2018 · 1 comment
Closed

Delete update-all-references script #50853

oli-obk opened this issue May 18, 2018 · 1 comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@oli-obk
Copy link
Contributor

oli-obk commented May 18, 2018

#50806 added the ./x.py test --bless flag which is better than the script in all ways except in having been used for a long time. Thus I left the scripts in the tree so we can use them if --bless fails.

Once this issue is a month old or so, we should delete the various copies of the update-reference and update-all-references scripts. (Unless --bless doesn't live up to its promise, then we should of course delay deleting the scripts).
@oli-obk oli-obk added the E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. label May 18, 2018
@Mark-Simulacrum Mark-Simulacrum added the C-cleanup Category: PRs that clean code up or issues documenting cleanup. label May 28, 2018
@ccesare ccesare mentioned this issue Jun 13, 2018
Merged
bors added a commit that referenced this issue Jun 13, 2018
@bors
Auto merge of #51542 - ccesare:remove_update-reference, r=oli-obk
5205ae8 
Removed various update-reference and update-all-references scripts

A PR that addresses #50853 changes that made `update-reference` and `update-all-references` scripts obsolete.
@oli-obk
Copy link
Contributor Author

oli-obk commented Jun 14, 2018

Thanks @ccesare for cleaning this up

@oli-obk oli-obk closed this as completed Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oli-obk @Mark-Simulacrum