Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kill rustc::cfg consumers #51002

Closed
2 of 3 tasks
nikomatsakis opened this issue May 23, 2018 · 2 comments
Closed
2 of 3 tasks

kill rustc::cfg consumers #51002

nikomatsakis opened this issue May 23, 2018 · 2 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@nikomatsakis
Copy link
Contributor

nikomatsakis commented May 23, 2018 •
edited by varkor
Loading

In general, rustc::cfg should be considered deprecated, and we ought to work to remove its consumers and rewrite them to operate on MIR:

  • UnconditionalRecursion lint
  • AST-based borrowck (that's what NLL is doing, of course)
  • librustc_driver::pretty::print_flowgraph()
@nikomatsakis nikomatsakis added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. C-cleanup Category: PRs that clean code up or issues documenting cleanup. labels May 23, 2018
@phungleson
Copy link
Contributor

Hey @nikomatsakis looks like some thing I can help with as rustc::cfg is relatively small.

Do you have any other suggestions for me to look further?

@wesleywiser wesleywiser mentioned this issue Sep 22, 2018
Merged
wesleywiser added a commit to wesleywiser/rust that referenced this issue Oct 4, 2018
@wesleywiser
Rewrite the UnconditionalRecursion lint to use MIR
f81d1dd 
Part of rust-lang#51002
pietroalbini added a commit to pietroalbini/rust that referenced this issue Oct 25, 2018
@pietroalbini
Rollup merge of rust-lang#54490 - wesleywiser:rewrite_it_in_mir, r=ol…
8ed2028 
…i-obk

Rewrite the `UnconditionalRecursion` lint to use MIR

Part of rust-lang#51002

r? @eddyb
bors added a commit that referenced this issue Oct 25, 2018
@bors
Auto merge of #54490 - wesleywiser:rewrite_it_in_mir, r=oli-obk
4bd4e41 
Rewrite the `UnconditionalRecursion` lint to use MIR

Part of #51002

r? @eddyb
@Mark-Simulacrum Mark-Simulacrum mentioned this issue Aug 31, 2019
Closed
@hanna-kruppe
Copy link
Contributor

This is done now: #64231 moved rustc::cfg into rustc_ast_borrowck which was then deleted wholesale in #64790.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@phungleson @nikomatsakis @hanna-kruppe