Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

primitive type never aka ! not indicated as unstable in the docs #54198

Closed
majewsky opened this issue Sep 13, 2018 · 0 comments · Fixed by #54207
Closed

primitive type never aka ! not indicated as unstable in the docs #54198

majewsky opened this issue Sep 13, 2018 · 0 comments · Fixed by #54207
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools

Comments

@majewsky
Copy link

As of now, the tracking issue for ! indicates that this type is still unstable, but the documentation at https://doc.rust-lang.org/std/primitive.never.html does not reflect that. It's missing the customary marker for experimental APIs.

@Havvy Havvy added the A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools label Sep 13, 2018
kennytm added a commit to kennytm/rust that referenced this issue Sep 14, 2018
…kennytm

re-mark the never docs as unstable

Fixes rust-lang#54198

This stability attribute was removed in rust-lang#47630, but not replaced with a `#[stable]` attribute, and when rust-lang#50121 reverted that stabilization, it didn't set the docs back to unstable. I'm concerned as to why it was allowed to not have the stability attribute at all, but at least this can put it back.

I'm nominating this for beta backport because it's a really small change, and right now our docs are in an awkward position where the `!` type is technically unstable to use, but the docs don't say so the same way any other library feature would. (And this is also the case *on stable* now, but i'm not suggesting a stable backport for a docs fix.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants