-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build errors with edition=2018 after clean cargo fix --edition
#55592
Labels
Comments
Incorrect warningswarning: unused extern crate
--> components/script_plugins/lib.rs:27:1
|
27 | extern crate rustc_plugin;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove it
|
= note: requested on the command line with `-W unused-extern-crates`
warning: unused extern crate
--> components/script_plugins/lib.rs:28:1
|
28 | extern crate syntax;
| ^^^^^^^^^^^^^^^^^^^^ help: remove it Making the suggested removal causes build errors. |
jackpot51
pushed a commit
to redox-os/ion
that referenced
this issue
Mar 15, 2019
More Info: #55592 - rust-lang/rust#55592
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
With
nightly-2018-11-01
in Servo, after finally gettingcargo fix --edition
to complete without warnings. (Which was not easy: rust-lang/rustfix#149, https:/rust-lang-nursery/rustfix/issues/150), I addededition = "2018"
to (almost) allCargo.toml
files.At this point, the theory is that
cargo check
should Just Work, but it doesn’t. I’ve hit multiple issues, let me know if they should be filed separately.Dependencies not known to Cargo
The "extern prelude" is one way to fix this, but another is to is a crate-local path
crate::proc_macro::TokenStream
to the name that is introduced byextern crate
.This feature is also missing a tracking issue, the error message points to the implementation PR: #54658 (comment)
Ambiguous imports
Migrating generated code
cargo fix
did fix similar cases in "normal" source files, but generated code needs to be fixed in the code generator.These were the remaining ones after I’d already taken care of the absolute paths.
New warnings
Not as much of an issue than build errors, but slightly unexpected: switching editions uncovered new
unused_mut
warnings that were not present before. Maybe this is because 2018 currently implies NLL / MIR-borrowck?The text was updated successfully, but these errors were encountered: