Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement await syntax #60016

Closed
nikomatsakis opened this issue Apr 16, 2019 · 3 comments · Fixed by #60586
Closed

Implement await syntax #60016

nikomatsakis opened this issue Apr 16, 2019 · 3 comments · Fixed by #60586
Assignees
@cramertj
Labels
A-async-await Area: Async & Await AsyncAwait-Polish Async-await issues that are part of the "polish" area T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@nikomatsakis
Copy link
Contributor

As of this writing, we have not settled the precise syntax we will use for await. However, we have decided that we want to decide -- so it makes sense to get started on implementation. This issue is focused purely on implementation issues; the question of what syntax to use is covered in #57640.
@nikomatsakis nikomatsakis added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-async-await Area: Async & Await AsyncAwait-Polish Async-await issues that are part of the "polish" area labels Apr 16, 2019
@cramertj
Copy link
Member

I've finished this, pending changes to whatever final syntax is chosen.

@estebank
Copy link
Contributor

CC #51751

@cramertj
Copy link
Member

@estebank Yeah, it fixes #51751 and #51719.

@cramertj cramertj mentioned this issue May 6, 2019
Merged
bors added a commit that referenced this issue May 7, 2019
@bors
Auto merge of #60586 - cramertj:await, r=oli-obk
33cde4a 
Implement built-in await syntax

Adds support for .await under the existing async_await feature gate.
Moves macro-like await! syntax to the await_macro feature gate.
Removes support for `await` as a non-keyword under the `async_await`
feature.

This new syntax is not final, but is the consensus solution proposed by the lang team, as explained in https://boats.gitlab.io/blog/post/await-decision/

Fix #51719
Fix #51751
Fix #60016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cramertj cramertj

Labels
A-async-await Area: Async & Await AsyncAwait-Polish Async-await issues that are part of the "polish" area T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement built-in await syntax cramertj/rust
3 participants
@nikomatsakis @estebank @cramertj