Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should Thumb bugs get increased visibility, e.g. Tier 1 status? #60880

Open
pnkfelix opened this issue May 16, 2019 · 5 comments
Open

Should Thumb bugs get increased visibility, e.g. Tier 1 status? #60880

pnkfelix opened this issue May 16, 2019 · 5 comments
Labels
I-needs-decision Issue: In need of a decision. O-Arm Target: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 state T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-lang Relevant to the language team, which will review and decide on the PR/issue. WG-embedded Working group: Embedded systems

Comments

@pnkfelix
Copy link
Member

Spawned off of discussion here: #58605 (comment)

Do we need to explicitly revise stuff in our tagging/tests/release processes to try to decrease risk of Thumb bugs?

Namely these two points:

we may want to expand the number of items tested in the thumb-* tests contained in https:/rust-lang/rust/tree/master/src/test/run-make

and:

There was a discussion at the 2018 all hands about making the thumb targets tier 1, however this was not done as @alexchrichton mentioned that the concept of tiers was going away, or was being retooled.

If not, I'd like to reintroduce the discussion of making the thumb targets an official tier one target, as it already has some of the ground work laid to claim this

@pnkfelix
Copy link
Member Author

cc @alexcrichton

@Centril Centril added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-lang Relevant to the language team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. I-needs-decision Issue: In need of a decision. O-Arm Target: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 state labels May 16, 2019
@pietroalbini
Copy link
Member

One of the questions we should try to solve is the requirements we want for tier 1 target and the process to promote them.

@Centril
Copy link
Contributor

Centril commented May 16, 2019

Another question is to clarify what Tier 1 means. For example:

  • Can it ever be demoted?
    • Under what circumstances? (e.g. people stopped using the target because it got really old)

@jonas-schievink jonas-schievink added the WG-embedded Working group: Embedded systems label May 16, 2019
@alexcrichton
Copy link
Member

I don't personally think this is really a question we can directly answer at this time in the sense that it feels tied up in a larger discussion about tiers, what they mean, etc. Until that higher level question is answered we don't have a direct answer to the question here other than "well we'll try to fix them in a timely fashion like all other bugs if they crop up"

@jonas-schievink
Copy link
Contributor

Another question is to clarify what Tier 1 means. For example:

  • Can it ever be demoted?

    • Under what circumstances? (e.g. people stopped using the target because it got really old)

This now has an answer in the form of #67724

Also: cc rust-lang/rfcs#2803

I hope to reopen the discussion on this as I am also interested in getting tier-1 embedded platform support.

@Amanieu Amanieu removed the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I-needs-decision Issue: In need of a decision. O-Arm Target: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 state T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-lang Relevant to the language team, which will review and decide on the PR/issue. WG-embedded Working group: Embedded systems
Projects
None yet
Development

No branches or pull requests

6 participants