-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compiler-rt missing from rustc-1.37.0-src.tar.gz #64239
Comments
Centril
added a commit
to Centril/rust
that referenced
this issue
Sep 7, 2019
…richton Include compiler-rt in the source tarball In rust-lang#60981 we switched to using src/llvm-project/compiler-rt inside compiler-builtins rather than a separate copy of it. In order to have the "c" feature turn on in builds from the source tarball, we need to include that path in its creation. fixes rust-lang#64239
cuviper
pushed a commit
to cuviper/rust
that referenced
this issue
Sep 13, 2019
In rust-lang#60981 we switched to using src/llvm-project/compiler-rt inside compiler-builtins rather than a separate copy of it. In order to have the "c" feature turn on in builds from the source tarball, we need to include that path in its creation. fixes rust-lang#64239
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In #60981 we switched to detecting compiler-rt's presence in
src/llvm-project/compiler-rt
and enabling thec
feature forcompiler-builtins
if present, falling back to rust-only otherwise.In the git checkout, this works fine, however the
compiler-rt
directory is missing from therustc-1.37.0-src.tar.gz
vendored source tarball. As a result, builds from this tarball fall back to rust-only implementations, resulting in possibly less optimized code.The text was updated successfully, but these errors were encountered: