Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression: inline, used attr no longer accepted in more places #82668

Closed
Mark-Simulacrum opened this issue Mar 1, 2021 · 5 comments
Closed

regression: inline, used attr no longer accepted in more places #82668

Mark-Simulacrum opened this issue Mar 1, 2021 · 5 comments
Assignees
@XAMPPRocky
Labels
regression-from-stable-to-stable Performance or correctness regression from one stable version to another. relnotes Marks issues that should be documented in the release notes of the next release. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Milestone
1.51.0

Comments

@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Mar 1, 2021 •
edited
Loading

inline:

used:

Filing primarily so that we can get this documented in release notes as a compatibility note (if it isn't already); cc @XAMPPRocky
@Mark-Simulacrum Mark-Simulacrum added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. regression-from-stable-to-beta Performance or correctness regression from stable to beta. labels Mar 1, 2021
@Mark-Simulacrum Mark-Simulacrum added this to the 1.51.0 milestone Mar 1, 2021
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Mar 1, 2021
@Mark-Simulacrum Mark-Simulacrum changed the title regression: inline attr no longer accepted in more places regression: inline, used attr no longer accepted in more places Mar 1, 2021
@Mark-Simulacrum Mark-Simulacrum mentioned this issue Mar 1, 2021
Closed
@camelid camelid added the relnotes Marks issues that should be documented in the release notes of the next release. label Mar 2, 2021
@lcnr
Copy link
Contributor

lcnr commented Mar 2, 2021

That's surprising, iirc the crater runs we did during the PRs didn't notice any regressions 🤔

@lcnr
Copy link
Contributor

lcnr commented Mar 2, 2021

inline PR is #77015

@apiraino apiraino removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Mar 3, 2021
@apiraino
Copy link
Contributor

apiraino commented Mar 3, 2021

(removing I-prioritize autolabel added from bot)

austin-ray added a commit to austin-ray/weechat-matrix-rs that referenced this issue Apr 4, 2021
@austin-ray
fix: remove #[used] from non-static fields
15e99e5 
Rust 1.51 has a regression restricting the `#[used]` attribute[0] to
static fields. As such, it's not possible to build `weechat-matrix-rs`
on stable or nightly Rust. According to the `#[used]` RFC[1], the
attribute is for static variables so it's unclear if the new behavior is
the correct one.

[0] rust-lang/rust#82668
[1] https://rust-lang.github.io/rfcs/2386-used.html
austin-ray added a commit to austin-ray/weechat-matrix-rs that referenced this issue Apr 4, 2021
@austin-ray
fix: remove #[used] from non-static fields
cab463f 
Rust 1.51 has a regression restricting the `#[used]` attribute[0] to
static fields. As such, it's not possible to build `weechat-matrix-rs`
on stable or nightly Rust. According to the `#[used]` RFC[1], the
attribute is for static variables so it's unclear if the new behavior is
the correct one.

However, to prevent clippy from complaining during CI, replace with
`#[allow(dead_code)]`

[0] rust-lang/rust#82668
[1] https://rust-lang.github.io/rfcs/2386-used.html
austin-ray added a commit to austin-ray/weechat-matrix-rs that referenced this issue Apr 7, 2021
@austin-ray
fix: remove #[used] from non-static fields
0179bf3 
Rust 1.51 has a regression restricting the `#[used]` attribute[0] to
static fields. As such, it's not possible to build `weechat-matrix-rs`
on stable or nightly Rust. According to the `#[used]` RFC[1], the
attribute is for static variables so it's unclear if the new behavior is
the correct one.

However, to prevent clippy from complaining during CI, replace with
`#[allow(dead_code)]`

[0] rust-lang/rust#82668
[1] https://rust-lang.github.io/rfcs/2386-used.html
@pietroalbini pietroalbini added regression-from-stable-to-stable Performance or correctness regression from one stable version to another. and removed regression-from-stable-to-beta Performance or correctness regression from stable to beta. labels Apr 30, 2021
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Apr 30, 2021
@pietroalbini
Copy link
Member

Moved this to regression-from-stable-to-stable as it affects 1.51. Feel free to close the issue if appropriate.

@Mark-Simulacrum
Copy link
Member Author

Closing - this was expected/accepted breakage.

@jyn514 jyn514 removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@XAMPPRocky XAMPPRocky

Labels
regression-from-stable-to-stable Performance or correctness regression from one stable version to another. relnotes Marks issues that should be documented in the release notes of the next release. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.51.0
Development

No branches or pull requests
8 participants
@pietroalbini @XAMPPRocky @Mark-Simulacrum @apiraino @jyn514 @lcnr @camelid @rustbot