Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: read_to_string import error #82670

Closed
Mark-Simulacrum opened this issue Mar 1, 2021 · 3 comments
Closed

regression: read_to_string import error #82670

Mark-Simulacrum opened this issue Mar 1, 2021 · 3 comments
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Milestone

Comments

@Mark-Simulacrum
Copy link
Member

I suspect this is a change in behavior for the resolver, cc @petrochenkov -- probably fixing a bug in practice, but in case it was unintentional seems good to flag.

@Mark-Simulacrum Mark-Simulacrum added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. regression-from-stable-to-beta Performance or correctness regression from stable to beta. labels Mar 1, 2021
@Mark-Simulacrum Mark-Simulacrum added this to the 1.51.0 milestone Mar 1, 2021
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Mar 1, 2021
@petrochenkov
Copy link
Contributor

This is not a resolver change, but a library addition of std::io::read_to_string (#80217).

Resolver tries pretty hard to resolve ambiguities like this arising from library additions (e.g. single import wins over glob import, two glob imports do not conflict unless the ambiguous name is actually used), but in case of two glob imports and an actually used ambiguous name we truly cannot do anything.

Addition of any new item to any library has a potential to cause breakage like this, so it is considered an acceptable breakage.

@Mark-Simulacrum
Copy link
Member Author

Sounds good. I missed that merged in 1.51, re-tagging libs.

@Mark-Simulacrum Mark-Simulacrum added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed I-prioritize Issue: Indicates that prioritization has been requested for this issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 1, 2021
@Mark-Simulacrum Mark-Simulacrum changed the title regression: resolver finds conflicting imports regression: read_to_string import error Mar 1, 2021
@JohnTitor
Copy link
Member

Triage: Closing this as an acceptable breakage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants