-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SimplifyBranchSame assumes discriminant is the same as variant index. #89485
Labels
A-mir-opt
Area: MIR optimizations
C-bug
Category: This is a bug.
I-unsound
Issue: A soundness hole (worst kind of bug), see: https://en.wikipedia.org/wiki/Soundness
P-critical
Critical priority
regression-from-stable-to-stable
Performance or correctness regression from one stable version to another.
Comments
rustbot
added
I-unsound
Issue: A soundness hole (worst kind of bug), see: https://en.wikipedia.org/wiki/Soundness
regression-from-stable-to-stable
Performance or correctness regression from one stable version to another.
I-prioritize
Issue: Indicates that prioritization has been requested for this issue.
labels
Oct 3, 2021
tmiasko
changed the title
SimplifyBranchSame assumes discriminants are the same as variant index.
SimplifyBranchSame assumes discriminant is the same as variant index.
Oct 3, 2021
After a quick godbolt it appears that the regression appear with Rust 1.48.0 |
A bisection seems to lead to 043f6d7, nightly 2020-09-26
|
Assigning priority as discussed in the Zulip thread of the Prioritization Working Group. @rustbot label -I-prioritize +P-critical |
rustbot
added
P-critical
Critical priority
and removed
I-prioritize
Issue: Indicates that prioritization has been requested for this issue.
labels
Oct 3, 2021
Looks like it is mostly likely caused by #76844 which is supposed to fix #76803. cc @simonvandel @wesleywiser |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-mir-opt
Area: MIR optimizations
C-bug
Category: This is a bug.
I-unsound
Issue: A soundness hole (worst kind of bug), see: https://en.wikipedia.org/wiki/Soundness
P-critical
Critical priority
regression-from-stable-to-stable
Performance or correctness regression from one stable version to another.
Originally found by @bonega when experimenting with discriminants starting from 1 in #88984 (comment).
@rustbot modify labels: +regression-from-stable-to-stable +I-unsound
The text was updated successfully, but these errors were encountered: