Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Beta] Clippy: Fix hang in vec_init_then_push #101808

Merged
merged 1 commit into from
Sep 17, 2022
Merged

[Beta] Clippy: Fix hang in vec_init_then_push #101808

merged 1 commit into from
Sep 17, 2022

Conversation

flip1995
Copy link
Member

Small Clippy ICE/hang fix backport before beta gets branched. We'd like to get this into stable ASAP. This fix is already in master as 1585932.

@rustbot
Copy link
Collaborator

rustbot commented Sep 14, 2022

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 14, 2022
@flip1995 flip1995 mentioned this pull request Sep 14, 2022
Merged
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=never p=1

@bors
Copy link
Contributor

bors commented Sep 16, 2022

📌 Commit 0b3a19a has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 16, 2022
@bors
Copy link
Contributor

bors commented Sep 16, 2022

⌛ Testing commit 0b3a19a with merge b31188e...

@bors
Copy link
Contributor

bors commented Sep 17, 2022

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing b31188e to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 17, 2022
@bors bors merged commit b31188e into rust-lang:beta Sep 17, 2022
@rustbot rustbot added this to the 1.64.0 milestone Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth approved these changes

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.
7 participants
@flip1995 @rustbot @rust-highfive @Mark-Simulacrum @bors @Manishearth @Jarcho