Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #102644

Merged
merged 16 commits into from
Oct 4, 2022
Merged

Rollup of 7 pull requests #102644

merged 16 commits into from
Oct 4, 2022

Commits on Oct 2, 2022

  1. Configuration menu
    Copy the full SHA
    f088e54 View commit details
    Browse the repository at this point in the history
  2. fix rust-lang#102320, suggest unwrap_or_else when a closure is passed…

    … to unwrap_or instead of suggesting calling it
    chenyukang committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    0188273 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2022

  1. Configuration menu
    Copy the full SHA
    177b3d2 View commit details
    Browse the repository at this point in the history
  2. rustdoc: remove font family CSS on .rustdoc-toggle summary::before

    This rule became irrelevant since c58246e
    made it so that the `summary::before` pseudo-element contains an SVG instead
    of text.
    notriddle committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    d33e113 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8dcecdb View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8a103f5 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4ae58d6 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b8a63a6 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    88dab8d View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2022

  1. Rollup merge of rust-lang#102441 - chenyukang:fix-102320-unwrap_or_el…

    …se, r=compiler-errors
    
    Suggest unwrap_or_else when a closure is given
    
    Fixes rust-lang#102320
    
    r? `@compiler-errors`
    matthiaskrgr authored Oct 4, 2022
    Configuration menu
    Copy the full SHA
    a2126e7 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#102547 - GuillaumeGomez:migrate-css-theme-s…

    …earch-result, r=notriddle,jsha
    
    Migrate CSS theme for search results
    
    Part of rust-lang#98460.
    
    Just like rust-lang#102237, I unified theme to how the `ayu` handles this one: only one color for the background when search results are focused or hovered.
    
    You can test it [here](https://rustdoc.crud.net/imperio/migrate-css-theme-search-result/lib2/index.html?search=coo).
    
    cc `@jsha`
    r? `@notriddle`
    
    PS: The repetition in GUI tests is getting out of hand so I opened GuillaumeGomez/browser-UI-test#363 to think about adding possibility to declare functions so we can greatly improve this.
    matthiaskrgr authored Oct 4, 2022
    Configuration menu
    Copy the full SHA
    f333436 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#102567 - compiler-errors:issue-102561, r=da…

    …vidtwco
    
    Delay evaluating lint primary message until after it would be suppressed
    
    Fixes rust-lang#102561
    Fixes rust-lang#102572
    matthiaskrgr authored Oct 4, 2022
    Configuration menu
    Copy the full SHA
    8a0fda2 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#102624 - notriddle:notriddle/summary-before…

    …, r=GuillaumeGomez
    
    rustdoc: remove font family CSS on `.rustdoc-toggle summary::before`
    
    This rule became irrelevant since c58246e made it so that the `summary::before` pseudo-element contains an SVG instead of text.
    matthiaskrgr authored Oct 4, 2022
    Configuration menu
    Copy the full SHA
    cdb114e View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#102628 - H4x5:master, r=scottmcm

    Change the parameter name of From::from to `value`
    
    The `From` trait is currently defined as:
    ```rust
    pub trait From<T>: Sized {
        fn from(_: T) -> Self;
    }
    ```
    
    The name of the argument is `_`. I am proposing to change it to `value`, ie.
    ```rust
    pub trait From<T>: Sized {
        fn from(value: T) -> Self;
    }
    ```
    
    This would be more consistent with the `TryFrom`, which looks like this:
    ```rust
    pub trait TryFrom<T>: Sized {
        type Error;
        fn try_from(value: T) -> Result<Self, Self::Error>;
    }
    ```
    
    The reason for this proposal is twofold:
    1. Consistency with the rest of the standard library. The `TryFrom` trait uses `value`, and no `From` implementation uses the default name (as it is quite useless).
    2. When generating trait implementations with rust-analyzer/IntelliJ, the parameter name is copied, and it always has to be changed.
    
    Optionally, another name like `x` could be used. I only propose `value` for consistency with `TryFrom`.
    
    Changing parameter names is not a breaking change.
    
    Note: this was originally posted as an internals thread [here](https://internals.rust-lang.org/t/change-the-argument-name-of-from-from/17480)
    matthiaskrgr authored Oct 4, 2022
    Configuration menu
    Copy the full SHA
    17c6582 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#102637 - andrewpollack:ignore-fuchsia-two-t…

    …ests, r=tmandry
    
    Ignore fuchsia on two compiler tests
    
    Adding `ignore-fuchsia` to two irrelevant compiler tests
    
    cc. `@djkoloski`
    
    r? `@tmandry`
    matthiaskrgr authored Oct 4, 2022
    Configuration menu
    Copy the full SHA
    f86ee78 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#102639 - nnethercote:improve-spans-splittin…

    …g, r=Aaron1011
    
    Improve spans when splitting multi-char operator tokens for proc macros.
    
    When a two-char (or three-char) operator token is split into single-char operator tokens before being passed to a proc macro, the single-char tokens are given the original span of length two (or three). This PR gives them more accurate spans.
    
    r? `@Aaron1011`
    cc `@petrochenkov`
    matthiaskrgr authored Oct 4, 2022
    Configuration menu
    Copy the full SHA
    185ca0f View commit details
    Browse the repository at this point in the history