-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 7 pull requests #102644
Rollup of 7 pull requests #102644
Commits on Oct 2, 2022
-
Configuration menu - View commit details
-
Copy full SHA for f088e54 - Browse repository at this point
Copy the full SHA f088e54View commit details -
fix rust-lang#102320, suggest unwrap_or_else when a closure is passed…
… to unwrap_or instead of suggesting calling it
Configuration menu - View commit details
-
Copy full SHA for 0188273 - Browse repository at this point
Copy the full SHA 0188273View commit details
Commits on Oct 3, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 177b3d2 - Browse repository at this point
Copy the full SHA 177b3d2View commit details -
rustdoc: remove font family CSS on
.rustdoc-toggle summary::before
This rule became irrelevant since c58246e made it so that the `summary::before` pseudo-element contains an SVG instead of text.
Configuration menu - View commit details
-
Copy full SHA for d33e113 - Browse repository at this point
Copy the full SHA d33e113View commit details -
Change the parameter name of From::from to
value
H4x5 authoredOct 3, 2022 Configuration menu - View commit details
-
Copy full SHA for 8dcecdb - Browse repository at this point
Copy the full SHA 8dcecdbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a103f5 - Browse repository at this point
Copy the full SHA 8a103f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ae58d6 - Browse repository at this point
Copy the full SHA 4ae58d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for b8a63a6 - Browse repository at this point
Copy the full SHA b8a63a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 88dab8d - Browse repository at this point
Copy the full SHA 88dab8dView commit details
Commits on Oct 4, 2022
-
Rollup merge of rust-lang#102441 - chenyukang:fix-102320-unwrap_or_el…
…se, r=compiler-errors Suggest unwrap_or_else when a closure is given Fixes rust-lang#102320 r? `@compiler-errors`
Configuration menu - View commit details
-
Copy full SHA for a2126e7 - Browse repository at this point
Copy the full SHA a2126e7View commit details -
Rollup merge of rust-lang#102547 - GuillaumeGomez:migrate-css-theme-s…
…earch-result, r=notriddle,jsha Migrate CSS theme for search results Part of rust-lang#98460. Just like rust-lang#102237, I unified theme to how the `ayu` handles this one: only one color for the background when search results are focused or hovered. You can test it [here](https://rustdoc.crud.net/imperio/migrate-css-theme-search-result/lib2/index.html?search=coo). cc `@jsha` r? `@notriddle` PS: The repetition in GUI tests is getting out of hand so I opened GuillaumeGomez/browser-UI-test#363 to think about adding possibility to declare functions so we can greatly improve this.
Configuration menu - View commit details
-
Copy full SHA for f333436 - Browse repository at this point
Copy the full SHA f333436View commit details -
Rollup merge of rust-lang#102567 - compiler-errors:issue-102561, r=da…
…vidtwco Delay evaluating lint primary message until after it would be suppressed Fixes rust-lang#102561 Fixes rust-lang#102572
Configuration menu - View commit details
-
Copy full SHA for 8a0fda2 - Browse repository at this point
Copy the full SHA 8a0fda2View commit details -
Rollup merge of rust-lang#102624 - notriddle:notriddle/summary-before…
…, r=GuillaumeGomez rustdoc: remove font family CSS on `.rustdoc-toggle summary::before` This rule became irrelevant since c58246e made it so that the `summary::before` pseudo-element contains an SVG instead of text.
Configuration menu - View commit details
-
Copy full SHA for cdb114e - Browse repository at this point
Copy the full SHA cdb114eView commit details -
Rollup merge of rust-lang#102628 - H4x5:master, r=scottmcm
Change the parameter name of From::from to `value` The `From` trait is currently defined as: ```rust pub trait From<T>: Sized { fn from(_: T) -> Self; } ``` The name of the argument is `_`. I am proposing to change it to `value`, ie. ```rust pub trait From<T>: Sized { fn from(value: T) -> Self; } ``` This would be more consistent with the `TryFrom`, which looks like this: ```rust pub trait TryFrom<T>: Sized { type Error; fn try_from(value: T) -> Result<Self, Self::Error>; } ``` The reason for this proposal is twofold: 1. Consistency with the rest of the standard library. The `TryFrom` trait uses `value`, and no `From` implementation uses the default name (as it is quite useless). 2. When generating trait implementations with rust-analyzer/IntelliJ, the parameter name is copied, and it always has to be changed. Optionally, another name like `x` could be used. I only propose `value` for consistency with `TryFrom`. Changing parameter names is not a breaking change. Note: this was originally posted as an internals thread [here](https://internals.rust-lang.org/t/change-the-argument-name-of-from-from/17480)
Configuration menu - View commit details
-
Copy full SHA for 17c6582 - Browse repository at this point
Copy the full SHA 17c6582View commit details -
Rollup merge of rust-lang#102637 - andrewpollack:ignore-fuchsia-two-t…
…ests, r=tmandry Ignore fuchsia on two compiler tests Adding `ignore-fuchsia` to two irrelevant compiler tests cc. `@djkoloski` r? `@tmandry`
Configuration menu - View commit details
-
Copy full SHA for f86ee78 - Browse repository at this point
Copy the full SHA f86ee78View commit details -
Rollup merge of rust-lang#102639 - nnethercote:improve-spans-splittin…
…g, r=Aaron1011 Improve spans when splitting multi-char operator tokens for proc macros. When a two-char (or three-char) operator token is split into single-char operator tokens before being passed to a proc macro, the single-char tokens are given the original span of length two (or three). This PR gives them more accurate spans. r? `@Aaron1011` cc `@petrochenkov`
Configuration menu - View commit details
-
Copy full SHA for 185ca0f - Browse repository at this point
Copy the full SHA 185ca0fView commit details