Make {str,[u8]}::eq_ignore_ascii_case const #104126
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both of these can trivially be implemented with already-const-stable language constructs/functions, so I figured it would make sense to make them const. I was going to make
make_ascii_{upper,lower}case
const too, but I realized that requires const_mut_refs andu8/char::make_ascii_*case
aren't even unstably const under that, so I figured I'd leave that for after that's stabilized. Also, unfortunately, neither of the existing implementations can just haveconst
added (maybeis_ascii
, but it'd need a bunch of extra unstably-const ptr methods), and alsoeq_ignore_ascii_case
codegen'd worse with the const-friendly while loop version, so I had to useconst_eval_select
for both.