Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a regression test for #104322 #105081

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Add a regression test for #104322 #105081

merged 1 commit into from
Dec 1, 2022

Conversation

weiznich
Copy link
Contributor

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 30, 2022
compiler-errors
compiler-errors reviewed Nov 30, 2022
View reviewed changes
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please amend the test and squash the commits

src/test/ui/traits/issue-104322.rs Outdated Show resolved Hide resolved
@compiler-errors
Copy link
Member

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 30, 2022

📌 Commit 42ff718 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 30, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 30, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 30, 2022
@matthiaskrgr
Rollup merge of rust-lang#105081 - weiznich:regression_test_for_10432…
102f118 
…2, r=compiler-errors

Add a regression test for rust-lang#104322

r? `@compiler-errors`
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 30, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 1, 2022
@bors
Auto merge of rust-lang#105095 - matthiaskrgr:rollup-9pu7vrx, r=matth…
744a97b 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#103065 (rustdoc-json: Document and Test that args can be patterns.)
 - rust-lang#104865 (Don't overwrite local changes when updating submodules)
 - rust-lang#104895 (Avoid Invalid code suggested when encountering unsatisfied trait bounds in derive macro code)
 - rust-lang#105063 (Rustdoc Json Tests: Don't assume that core::fmt::Debug will always have one item.)
 - rust-lang#105064 (rustdoc: add comment to confusing CSS `main { min-width: 0 }`)
 - rust-lang#105074 (Add Nicholas Bishop to `.mailmap`)
 - rust-lang#105081 (Add a regression test for rust-lang#104322)
 - rust-lang#105086 (rustdoc: clean up sidebar link CSS)
 - rust-lang#105091 (add Tshepang Mbambo to .mailmap)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6c4b5a2 into rust-lang:master Dec 1, 2022
@rustbot rustbot added this to the 1.67.0 milestone Dec 1, 2022
@pnkfelix pnkfelix mentioned this pull request Dec 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors left review comments

@Rageking8 Rageking8 Rageking8 left review comments

Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.
5 participants
@weiznich @compiler-errors @bors @Rageking8 @rustbot