Refactor try_execute_query

[Zoxc]

This merges JobOwner::try_start into try_execute_query, removing TryGetJob in the processes. 3 new functions are extracted from try_execute_query: execute_job, cycle_error and wait_for_query. This makes the control flow a bit clearer and improves performance.

Based on #109046.

Benchmark	Before	After
	Time	Time	%
🟣 clap:check	1.7134s	1.7061s	-0.43%
🟣 hyper:check	0.2519s	0.2510s	-0.35%
🟣 regex:check	0.9517s	0.9481s	-0.38%
🟣 syn:check	1.5389s	1.5338s	-0.33%
🟣 syntex_syntax:check	5.9488s	5.9258s	-0.39%
Total	10.4048s	10.3647s	-0.38%
Summary	1.0000s	0.9962s	-0.38%

r? @cjgillot

[Kobzol]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 089a37253c982042d3a9ef64d1dd4c947480f5cb with merge 59af7c98016d38ed9f14e4ed4770cacb57e1a072...

[bors]

☀️ Try build successful - checks-actions
Build commit: 59af7c98016d38ed9f14e4ed4770cacb57e1a072 (59af7c98016d38ed9f14e4ed4770cacb57e1a072)

[rust-timer]

Finished benchmarking commit (59af7c98016d38ed9f14e4ed4770cacb57e1a072): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.5%	[2.5%, 2.5%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.1%	[-3.9%, -2.5%]	3
All ❌✅ (primary)	2.5%	[2.5%, 2.5%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

[cjgillot]

@bors r+

[bors]

📌 Commit ced33ad has been approved by cjgillot

It is now in the queue for this repository.

[bors]

⌛ Testing commit ced33ad with merge b72e896...

[bors]

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing b72e896 to master...

[rust-timer]

Finished benchmarking commit (b72e896): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.7%, 0.8%]	4
Regressions ❌ (secondary)	0.5%	[0.3%, 0.7%]	8
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.7%	[0.7%, 0.8%]	4

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.1%	[2.4%, 3.9%]	6
Regressions ❌ (secondary)	2.5%	[0.7%, 4.7%]	100
Improvements ✅ (primary)	-1.9%	[-1.9%, -1.9%]	1
Improvements ✅ (secondary)	-0.5%	[-0.5%, -0.4%]	2
All ❌✅ (primary)	2.4%	[-1.9%, 3.9%]	7

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.3%	[0.5%, 2.1%]	2
Improvements ✅ (primary)	-1.1%	[-1.1%, -1.1%]	1
Improvements ✅ (secondary)	-0.5%	[-0.6%, -0.4%]	3
All ❌✅ (primary)	-1.1%	[-1.1%, -1.1%]	1

[rylev]

hello-world (the only benchmark impacted here) has been noisy lately unfortunately...

@rustbot label: +perf-regression-triaged