Only implement Fn* traits for extern "Rust" safe function pointers and items #109441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @compiler-errors (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
S-waiting-on-review
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
oli-obk
force-pushed
the
fn_trait_new_solver
branch
from
0a7a607
to
e6111e2
Compare
oli-obk
force-pushed
the
fn_trait_new_solver
branch
from
e6111e2
to
a00413f
Compare
compiler-errors
approved these changes
Mar 21, 2023
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 21, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#96391 (Windows: make `Command` prefer non-verbatim paths) - rust-lang#108164 (Drop all messages in bounded channel when destroying the last receiver) - rust-lang#108729 (fix: modify the condition that `resolve_imports` stops) - rust-lang#109336 (Constrain const vars to error if const types are mismatched) - rust-lang#109403 (Avoid ICE of attempt to add with overflow in emitter) - rust-lang#109415 (Refactor `handle_missing_lit`.) - rust-lang#109441 (Only implement Fn* traits for extern "Rust" safe function pointers and items) - rust-lang#109446 (Do not suggest bounds restrictions for synthesized RPITITs) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since calling the function via an
Fntrait will assumeextern "Rust"ABI and not do any safety checks, only safeextern "Rust"function can implement theFntraits. This syncs the logic between the old solver and the new solver.r? @compiler-errors