remove inline const deadcode in typeck #110893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
r? @nbdd0121 |
|
Failed to set assignee to
|
|
oh |
compiler-errors
approved these changes
Apr 27, 2023
|
@bors r+ |
bors
added
S-waiting-on-bors
| @@ -221,12 +221,6 @@ fn typeck_with_fallback<'tcx>( | |||
| })) | |||
| } else if let Node::AnonConst(_) = node { | |||
| match tcx.hir().get(tcx.hir().parent_id(id)) { | |||
| Node::Expr(&hir::Expr { | |||
There was a problem hiding this comment.
would be nice to assert that we're only calling typeck_with_fallback on things that aren't typeck children, just in case someone messes with that typeck_root_def_id != def_id branch above, but whatever
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 28, 2023
Rollup of 7 pull requests Successful merges: - rust-lang#109702 (configure --set support list as arguments) - rust-lang#110620 (Document `const {}` syntax for `std::thread_local`.) - rust-lang#110721 (format panic message only once) - rust-lang#110881 (refactor(docs): remove macro resolution fallback) - rust-lang#110893 (remove inline const deadcode in typeck) - rust-lang#110898 (Remove unused std::sys_common::thread_local_key::Key) - rust-lang#110909 (Skip `rustc` version detection on macOS) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inline consts get typeck'd with their parent so this is not reachable