Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #114130

Merged
merged 17 commits into from
Jul 27, 2023
Merged

Rollup of 7 pull requests #114130

merged 17 commits into from
Jul 27, 2023

Commits on Jul 24, 2023

  1. typos

    tshepang authored Jul 24, 2023
    Configuration menu
    Copy the full SHA
    9f8c249 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. rustdoc: stylistic changes

    fmease committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    f68f37d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    28d40f1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cf325e8 View commit details
    Browse the repository at this point in the history
  4. Bump syn dependency

    oli-obk committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    ad83037 View commit details
    Browse the repository at this point in the history
  5. docs: fmt::Debug*: Fix comments for finish method.

    In the code sample for the `finish` method on `DebugList`,
    `DebugMap`, and `DebugSet`, refer to finishing the list, map, or
    set, rather than struct as it did.
    waywardmonkeys committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    9f47ff8 View commit details
    Browse the repository at this point in the history
  6. Fix URL for rmatches

    veera-sivarajan committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    0169ce9 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. Revert "don't uniquify regions when canonicalizing"

    This reverts commit 171f541.
    compiler-errors committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    99f60ec View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1ffc6ca View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    99a9a63 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b8414fe View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#114059 - fmease:rustdoc-fix-x-crate-impl-si…

    …zed, r=GuillaumeGomez
    
    rustdoc: fix cross-crate `impl Sized` & `impl ?Sized`
    
    Previously, cross-crate impl-Trait (APIT, RPIT, etc.) that only consists of a single `Sized` bound (modulo outlives-bounds) and ones that are `?Sized` were incorrectly rendered. To give you a taste (before vs. after):
    
    ```diff
    - fn sized(x: impl ) -> impl
    + fn sized(x: impl Sized) -> impl Sized
    
    - fn sized_outlives<'a>(x: impl 'a) -> impl 'a
    + fn sized_outlives<'a>(x: impl Sized + 'a) -> impl Sized + 'a
    
    - fn maybe_sized(x: &impl ) -> &impl
    + fn maybe_sized(x: &impl ?Sized) -> &impl ?Sized
    
    - fn debug_maybe_sized(x: &impl Debug) -> &impl ?Sized + Debug
    + fn debug_maybe_sized(x: &(impl Debug + ?Sized)) -> &(impl Debug + ?Sized)
    ```
    
    Moreover, we now surround impl-Trait that has multiple bounds with parentheses if they're the pointee of a reference or raw pointer type. This affects both local and cross-crate docs. The current output isn't correct (rustc would emit the error *ambiguous `+` in a type* if we fed the rendered code back to it).
    
    ---
    
    Best reviewed commit by commit :)
    
    `@rustbot` label A-cross-crate-reexports
    GuillaumeGomez authored Jul 27, 2023
    Configuration menu
    Copy the full SHA
    1fa0c4d View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#114088 - oli-obk:syn, r=davidtwco

    Bump syn dependency
    
    r? `@davidtwco` because this affects diagnostics derive diagnostics (yes this sentence is grammatically correct)
    GuillaumeGomez authored Jul 27, 2023
    Configuration menu
    Copy the full SHA
    f7123db View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#114091 - waywardmonkeys:doc-fmt-finish-comm…

    …ents, r=GuillaumeGomez
    
    docs: fmt::Debug*: Fix comments for finish method.
    
    In the code sample for the `finish` method on `DebugList`, `DebugMap`, and `DebugSet`, refer to finishing the list, map, or set, rather than struct as it did.
    GuillaumeGomez authored Jul 27, 2023
    Configuration menu
    Copy the full SHA
    ee54896 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#114109 - veera-sivarajan:fix-str-docs, r=Gu…

    …illaumeGomez
    
    Docs: Fix URL for `rmatches`
    
    This PR fixes a link to `str::rmatches()` by pointing it to the correct URL.
    GuillaumeGomez authored Jul 27, 2023
    Configuration menu
    Copy the full SHA
    eb1f1a4 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#114117 - compiler-errors:return-to-uniq, r=…

    …lcnr
    
    Restore region uniquification in the new solver 🎉
    
    All of the bugs that were "due" to uniquification have been settled via other means (e.g. bidirectional alias-relate, param-env incompleteness, etc).
    
    Firstly, revert the functional changes in rust-lang#110180. 😸
    
    Secondly, we need to ignore regions when considering if a goal has changed (the "has_changed" boolean returned from `evaluate_goal`) -- otherwise, because we're doing region uniquification, we may perpetually consider a goal to be changed. See the UI test I committed for an explanation.
    GuillaumeGomez authored Jul 27, 2023
    Configuration menu
    Copy the full SHA
    0bebfa3 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#114123 - oli-obk:tait_wtf, r=WaffleLapkin

    Turns out opaque types can have hidden types registered during mir validation
    
    See the newly added test's documentation for an explanation.
    
    fixes rust-lang#114121
    GuillaumeGomez authored Jul 27, 2023
    Configuration menu
    Copy the full SHA
    218e88e View commit details
    Browse the repository at this point in the history