coverage: Move unused-function synthesis into its own submodule #115505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @TaKO8Ki (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
Swatinem
approved these changes
Sep 3, 2023
|
This is going to conflict with #114656, so I'll push an updated version once that's merged. |
|
☔ The latest upstream changes (presumably #115671) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Closing this for now because it's going to conflict with other work that's more important, so it isn't worth the hassle right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the tasks performed by coverage instrumentation is to synthesize stubs for unused functions, so that they can have coverage mappings associated with them and be processed normally by the LLVM coverage reporting tools.
This code is somewhat complex, and can be cleanly separated from what the other modules are doing, so this PR moves it into its own
unusedsubmodule.This is purely moving existing code around, so there should be no behavioural changes.