Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 5 pull requests #116443

Merged
merged 15 commits into from
Oct 5, 2023
Merged

Rollup of 5 pull requests #116443

merged 15 commits into from
Oct 5, 2023

Commits on Oct 4, 2023

  1. Fix misuses of a vs an

    Signed-off-by: cui fliter <[email protected]>
    cuishuang committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    f44d116 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a198aff View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    867cc41 View commit details
    Browse the repository at this point in the history
  4. Tweak wording of E0562

    estebank committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    041e54b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9266270 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a46ccd8 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    137b6d0 View commit details
    Browse the repository at this point in the history
  8. Fix clippy

    compiler-errors committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    89b14ae View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    1f079cf View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    dd5f26c View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. Rollup merge of rust-lang#116223 - catandcoder:master, r=cjgillot

    Fix misuses of a vs an
    
    Fixes the misuse of "a" vs "an", according to English grammatical
    expectations and using https://www.a-or-an.com/
    workingjubilee authored Oct 5, 2023
    Configuration menu
    Copy the full SHA
    ea3454e View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#116296 - compiler-errors:default-return, r=…

    …estebank
    
    More accurately point to where default return type should go
    
    When getting the "default return type" span, instead of pointing to the low span of the next token, point to the high span of the previous token. This:
    
    1. Makes forming return type suggestions more uniform, since we expect them all in the same place.
    2. Arguably makes labels easier to understand, since we're pointing to where the implicit `-> ()` would've gone, rather than the starting brace or the semicolon.
    
    r? ```@estebank```
    workingjubilee authored Oct 5, 2023
    Configuration menu
    Copy the full SHA
    cfce3a9 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#116429 - fmease:clean-up-struct-field-suggs…

    …, r=compiler-errors
    
    Diagnostics: Be more careful when suggesting struct fields
    
    Consolidate the various places which filter out struct fields that shouldn't be suggested into a single function.
    
    Previously, each of those code paths had slightly different and incomplete metrics for no good reason. Now, there's only a single 'complete' metric (namely `is_field_suggestable`) which also filters out hygienic fields that come from different syntax contexts.
    
    Fixes rust-lang#116334.
    workingjubilee authored Oct 5, 2023
    Configuration menu
    Copy the full SHA
    a9a389c View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#116431 - estebank:issue-80476, r=compiler-e…

    …rrors
    
    Tweak wording of E0562
    
    Fix rust-lang#80476.
    workingjubilee authored Oct 5, 2023
    Configuration menu
    Copy the full SHA
    d7b02c3 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#116432 - notriddle:master, r=fmease

    rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 2)
    
    Follow up rust-lang#116214
    workingjubilee authored Oct 5, 2023
    Configuration menu
    Copy the full SHA
    4a14a80 View commit details
    Browse the repository at this point in the history