Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 5 pull requests #117264

Closed
wants to merge 16 commits into from
Closed

Conversation

TaKO8Ki
Copy link
Member

@TaKO8Ki TaKO8Ki commented Oct 27, 2023

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

meysam81 and others added 16 commits August 20, 2023 14:54
…-to-docs, r=ehuss

feat(docs): add cargo-pgo to PGO documentation 📝

fixes rust-lang#114995
Suggest assoc fn `new` when trying to build tuple struct with private fields

Fix rust-lang#22488.
Tweak suggestion span for outer attr and point at item following invalid inner attr

After:

```
error: `unix_sigpipe` attribute cannot be used at crate level
  --> $DIR/unix_sigpipe-crate.rs:2:1
   |
LL | #![unix_sigpipe = "inherit"]
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
LL |
LL | fn main() {}
   | ------------ the inner attribute doesn't annotate this function
   |
help: perhaps you meant to use an outer attribute
   |
LL - #![unix_sigpipe = "inherit"]
LL + #[unix_sigpipe = "inherit"]
   |
```

Before:

```
error: `unix_sigpipe` attribute cannot be used at crate level
  --> $DIR/unix_sigpipe-crate.rs:2:1
   |
LL | #![unix_sigpipe = "inherit"]
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
help: perhaps you meant to use an outer attribute
   |
LL | #[unix_sigpipe = "inherit"]
   | ~~~~~~~~~~~~~~~~~~~~~~~~~~~
```

CC rust-lang#89566.
…pl, r=petrochenkov

Cleanup and improve `--check-cfg` implementation

This PR removes some indentation in the code, as well as preventing some bugs/misusages and fix a nit in the doc.

r? ``@petrochenkov`` (maybe)
…llect-into-fix-typo, r=the8472

Fix documentation typo in std::iter::Iterator::collect_into
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Oct 27, 2023
@TaKO8Ki
Copy link
Member Author

TaKO8Ki commented Oct 27, 2023

@bors r+ rollup=never p=5

@bors
Copy link
Contributor

bors commented Oct 27, 2023

📌 Commit ce4d5aa has been approved by TaKO8Ki

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 27, 2023
@bors
Copy link
Contributor

bors commented Oct 27, 2023

⌛ Testing commit ce4d5aa with merge 3a9a2d1...

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 27, 2023
Rollup of 5 pull requests

Successful merges:

 - rust-lang#114998 (feat(docs): add cargo-pgo to PGO documentation 📝)
 - rust-lang#116858 (Suggest assoc fn `new` when trying to build tuple struct with private fields)
 - rust-lang#116868 (Tweak suggestion span for outer attr and point at item following invalid inner attr)
 - rust-lang#117025 (Cleanup and improve `--check-cfg` implementation)
 - rust-lang#117240 (Fix documentation typo in std::iter::Iterator::collect_into)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Contributor

bors commented Oct 27, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 27, 2023
@TaKO8Ki
Copy link
Member Author

TaKO8Ki commented Oct 27, 2023

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 27, 2023
@TaKO8Ki TaKO8Ki deleted the rollup-6jl1ynm branch October 27, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants