Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 5 pull requests #118152

Merged
merged 12 commits into from
Nov 22, 2023
Merged

Rollup of 5 pull requests #118152

merged 12 commits into from
Nov 22, 2023

Commits on Nov 20, 2023

  1. Configuration menu
    Copy the full SHA
    0000b35 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    273dc22 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2023

  1. Add VarDebugInfo to Stable MIR

    ouz-a committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    018b859 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d0dd19a View commit details
    Browse the repository at this point in the history
  3. remove quotation from filename

    ouz-a committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    0b25415 View commit details
    Browse the repository at this point in the history
  4. rustdoc-search: clean up checkPath

    This computes the same result with less code by computing many of
    the old checks at once:
    
    * It won't enter the loop if clength > length, because then the
      result of length - clength will be negative and the
      loop conditional will fail.
    * i + clength will never be greater than length, because it
      starts out as i = length - clength, implying that i + clength
      equals length, and it only goes down from there.
    * The aborted variable is replaced with control flow.
    notriddle committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    d82a085 View commit details
    Browse the repository at this point in the history
  5. rustdoc-search: make primitives and keywords less special

    The search sorting code already sorts by item type discriminant,
    putting things with smaller discriminants first. There was
    also a special case for sorting keywords and primitives earlier,
    and this commit removes it by giving them lower discriminants.
    
    The sorting code has another criteria where items with descriptions
    appear earlier than items without, and that criteria has higher
    priority than the item type. This shouldn't matter, though,
    because primitives and keywords normally only appear in the
    standard library, and it always gives them descriptions.
    notriddle committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    28f17d9 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#117972 - ouz-a:stable_debuginfo, r=celinval

    Add VarDebugInfo to Stable MIR
    
    Previously we omitted `VarDebugInfo` because we didn't have `Projection` now that rust-lang#117517 is merged it's possible to add `VarDebugInfo` information in `Body`. This PR adds stable version of the `VarDebugInfo` to `Body`
    
    r? ```@celinval```
    matthiaskrgr authored Nov 21, 2023
    Configuration menu
    Copy the full SHA
    a98698e View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#118109 - notriddle:notriddle/search-cleanup…

    …-2, r=GuillaumeGomez
    
    rustdoc-search: simplify `checkPath` and `sortResults`
    
    These two commits reduce the amount of code in search.js with no noticeable change in performance.
    
    https://notriddle.com/rustdoc-html-demo-5/profile-5/index.html
    matthiaskrgr authored Nov 21, 2023
    Configuration menu
    Copy the full SHA
    bdb929e View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#118110 - compiler-errors:defining-anchor, r…

    …=aliemjay
    
    Document `DefiningAnchor` a bit more
    
    r? types
    matthiaskrgr authored Nov 21, 2023
    Configuration menu
    Copy the full SHA
    a11be28 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#118112 - compiler-errors:index-ambiguity-ic…

    …e, r=aliemjay
    
    Don't ICE when ambiguity is found when selecting `Index` implementation in typeck
    
    Fixes rust-lang#118111
    
    The problem here is when we're manually "selecting" an impl for `base_ty: Index<?0>`, we don't consider placeholder region errors (leak check) or ambiguous predicates. Those can lead to us not actually emitting any fulfillment errors on line 3131.
    matthiaskrgr authored Nov 21, 2023
    Configuration menu
    Copy the full SHA
    802f71b View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#118135 - ouz-a:fix_stable_span, r=celinval

    Remove quotation from filename in stable_mir
    
    Previously we had quotation marks in filenames which is obviously wrong this fixes that.
    
    r? ```@celinval```
    matthiaskrgr authored Nov 21, 2023
    Configuration menu
    Copy the full SHA
    914891f View commit details
    Browse the repository at this point in the history