tidy: reduce allocs #120023

klensy · 2024-01-16T13:47:45Z

this reduces allocs in tidy from (dhat output)

==31349== Total:     1,365,199,543 bytes in 4,774,213 blocks
==31349== At t-gmax: 10,975,708 bytes in 66,093 blocks
==31349== At t-end:  2,880,947 bytes in 12,332 blocks
==31349== Reads:     5,210,008,956 bytes
==31349== Writes:    1,280,920,127 bytes

to

==66633== Total:     791,565,538 bytes in 3,503,144 blocks
==66633== At t-gmax: 10,914,511 bytes in 65,997 blocks
==66633== At t-end:  395,531 bytes in 941 blocks
==66633== Reads:     4,249,388,949 bytes
==66633== Writes:    814,119,580 bytes

~~by wrapping regex and updating ignore (effect probably not only from ignore, didn't measured)~~

also moves one more regex into Lazy to reduce regex rebuilds.

rustbot · 2024-01-16T13:47:53Z

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

rustbot · 2024-01-16T13:47:56Z

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

src/tools/miropt-test-tools/Cargo.toml

src/tools/miropt-test-tools/src/lib.rs

Noratrieb · 2024-01-16T15:37:03Z

Is tidy any faster wall-time wise with this?

klensy · 2024-01-16T16:56:29Z

Is tidy any faster wall-time wise with this?

Can't detect any visible speedup, for me it runs ~10 secs before/after warmed up (maybe my slow hdd?)

klensy · 2024-01-16T20:29:17Z

@rustbot author

src/tools/miropt-test-tools/src/lib.rs

klensy · 2024-01-22T12:27:04Z

@rustbot ready

Mark-Simulacrum · 2024-01-27T18:00:16Z

@bors r+

bors · 2024-01-27T18:00:19Z

📌 Commit 3249174 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

tidy: reduce allocs this reduces allocs in tidy from (dhat output) ``` ==31349== Total: 1,365,199,543 bytes in 4,774,213 blocks ==31349== At t-gmax: 10,975,708 bytes in 66,093 blocks ==31349== At t-end: 2,880,947 bytes in 12,332 blocks ==31349== Reads: 5,210,008,956 bytes ==31349== Writes: 1,280,920,127 bytes ``` to ``` ==66633== Total: 791,565,538 bytes in 3,503,144 blocks ==66633== At t-gmax: 10,914,511 bytes in 65,997 blocks ==66633== At t-end: 395,531 bytes in 941 blocks ==66633== Reads: 4,249,388,949 bytes ==66633== Writes: 814,119,580 bytes ``` by wrapping regex and updating `ignore` (effect probably not only from `ignore`, didn't measured)

nnethercote · 2024-01-30T08:43:53Z

Nice to see DHAT being useful :)

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#120023 (tidy: reduce allocs) - rust-lang#120214 (match lowering: consistently lower bindings deepest-first) - rust-lang#120396 (Account for unbounded type param receiver in suggestions) - rust-lang#120423 (update indirect structural match lints to match RFC and to show up for dependencies) - rust-lang#120435 (Suggest name value cfg when only value is used for check-cfg) - rust-lang#120507 (Account for non-overlapping unmet trait bounds in suggestion) - rust-lang#120521 (Make `NonZero` constructors generic.) - rust-lang#120527 (Switch OwnedStore handle count to AtomicU32) r? `@ghost` `@rustbot` modify labels: rollup

tidy: reduce allocs this reduces allocs in tidy from (dhat output) ``` ==31349== Total: 1,365,199,543 bytes in 4,774,213 blocks ==31349== At t-gmax: 10,975,708 bytes in 66,093 blocks ==31349== At t-end: 2,880,947 bytes in 12,332 blocks ==31349== Reads: 5,210,008,956 bytes ==31349== Writes: 1,280,920,127 bytes ``` to ``` ==66633== Total: 791,565,538 bytes in 3,503,144 blocks ==66633== At t-gmax: 10,914,511 bytes in 65,997 blocks ==66633== At t-end: 395,531 bytes in 941 blocks ==66633== Reads: 4,249,388,949 bytes ==66633== Writes: 814,119,580 bytes ``` by wrapping regex and updating `ignore` (effect probably not only from `ignore`, didn't measured)

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#120023 (tidy: reduce allocs) - rust-lang#120396 (Account for unbounded type param receiver in suggestions) - rust-lang#120435 (Suggest name value cfg when only value is used for check-cfg) - rust-lang#120507 (Account for non-overlapping unmet trait bounds in suggestion) - rust-lang#120520 (Some cleanups around diagnostic levels.) - rust-lang#120575 (Simplify codegen diagnostic handling) - rust-lang#120670 (cleanup effect var handling) Failed merges: - rust-lang#120423 (update indirect structural match lints to match RFC and to show up for dependencies) r? `@ghost` `@rustbot` modify labels: rollup

matthiaskrgr · 2024-02-05T18:57:24Z

@bors r- rollup=never
I suspect that messing with the deps caused this failure #120679 (comment)

similar problems related to memchr were also reported here #120177 (comment)

klensy · 2024-02-12T10:47:38Z

Removed updated crates from Cargo.lock, as they break build, see linked errors in rollup and PR.
@rustbot ready

bors · 2024-02-16T23:37:09Z

☔ The latest upstream changes (presumably #120881) made this pull request unmergeable. Please resolve the merge conflicts.

yes, once_cell better, but ... this reduces from ==31349== Total: 1,365,199,543 bytes in 4,774,213 blocks ==31349== At t-gmax: 10,975,708 bytes in 66,093 blocks ==31349== At t-end: 2,880,947 bytes in 12,332 blocks ==31349== Reads: 5,210,008,956 bytes ==31349== Writes: 1,280,920,127 bytes to ==47796== Total: 821,467,407 bytes in 3,955,595 blocks ==47796== At t-gmax: 10,976,209 bytes in 66,100 blocks ==47796== At t-end: 2,944,016 bytes in 12,490 blocks ==47796== Reads: 4,788,959,023 bytes ==47796== Writes: 975,493,639 bytes miropt-test-tools: remove regex usage this removes regex usage and slightly refactors ext stripping in one case

klensy · 2024-02-17T09:47:06Z

Rebased. Added one more regex from compiletest to static build (new from #120881).

Mark-Simulacrum · 2024-02-17T15:26:19Z

@bors r+

bors · 2024-02-17T15:26:22Z

📌 Commit f6fa03b has been approved by Mark-Simulacrum

It is now in the queue for this repository.

bors · 2024-02-17T16:22:47Z

⌛ Testing commit f6fa03b with merge 12b5498...

bors · 2024-02-17T18:19:34Z

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 12b5498 to master...

rust-timer · 2024-02-17T19:33:26Z

Finished benchmarking commit (12b5498): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.3%	[0.3%, 0.3%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.6%	[-3.6%, -3.6%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.3%	[-3.3%, -3.3%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.2%	[2.1%, 2.3%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.2%	[-2.2%, -2.2%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 638.332s -> 640.589s (0.35%)
Artifact size: 306.33 MiB -> 308.38 MiB (0.67%)

rustbot assigned Mark-Simulacrum Jan 16, 2024

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jan 16, 2024

Mark-Simulacrum reviewed Jan 16, 2024

View reviewed changes

src/tools/miropt-test-tools/Cargo.toml Outdated Show resolved Hide resolved

src/tools/miropt-test-tools/src/lib.rs Outdated Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 16, 2024

klensy force-pushed the tidy-alloc branch 2 times, most recently from 1d76672 to 42bdc5b Compare January 22, 2024 10:12

klensy commented Jan 22, 2024

View reviewed changes

src/tools/miropt-test-tools/src/lib.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

klensy commented Jan 22, 2024

View reviewed changes

src/tools/miropt-test-tools/src/lib.rs Show resolved Hide resolved

klensy force-pushed the tidy-alloc branch from 42bdc5b to 822b228 Compare January 22, 2024 10:24

This comment has been minimized.

Sign in to view

klensy force-pushed the tidy-alloc branch from 822b228 to 3249174 Compare January 22, 2024 10:50

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 22, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 27, 2024

matthiaskrgr mentioned this pull request Jan 27, 2024

Rollup of 10 pull requests #120431

Closed

matthiaskrgr mentioned this pull request Feb 5, 2024

Rollup of 5 pull requests #120674

Closed

matthiaskrgr mentioned this pull request Feb 5, 2024

Rollup of 7 pull requests #120679

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 5, 2024

klensy mentioned this pull request Feb 5, 2024

cargo update #120454

Merged

klensy force-pushed the tidy-alloc branch from a9ba383 to 60457aa Compare February 12, 2024 08:55

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 12, 2024

klensy added 2 commits February 17, 2024 12:29

compiletest: fix regex rebuilds

f6fa03b

klensy force-pushed the tidy-alloc branch from 60457aa to f6fa03b Compare February 17, 2024 09:40

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 17, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 17, 2024

bors merged commit 12b5498 into rust-lang:master Feb 17, 2024
12 checks passed

rustbot added this to the 1.78.0 milestone Feb 17, 2024

bors mentioned this pull request Feb 17, 2024

Move the extra directives for Mode::CoverageRun into iter_header #121233

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tidy: reduce allocs #120023

tidy: reduce allocs #120023

klensy commented Jan 16, 2024 •

edited

Loading

rustbot commented Jan 16, 2024

rustbot commented Jan 16, 2024

Noratrieb commented Jan 16, 2024

klensy commented Jan 16, 2024

klensy commented Jan 16, 2024

This comment has been minimized.

This comment has been minimized.

klensy commented Jan 22, 2024

Mark-Simulacrum commented Jan 27, 2024

bors commented Jan 27, 2024

nnethercote commented Jan 30, 2024

matthiaskrgr commented Feb 5, 2024

klensy commented Feb 12, 2024

bors commented Feb 16, 2024

klensy commented Feb 17, 2024

Mark-Simulacrum commented Feb 17, 2024

bors commented Feb 17, 2024

bors commented Feb 17, 2024

bors commented Feb 17, 2024

rust-timer commented Feb 17, 2024

tidy: reduce allocs #120023

tidy: reduce allocs #120023

Conversation

klensy commented Jan 16, 2024 • edited Loading

rustbot commented Jan 16, 2024

rustbot commented Jan 16, 2024

Noratrieb commented Jan 16, 2024

klensy commented Jan 16, 2024

klensy commented Jan 16, 2024

This comment has been minimized.

This comment has been minimized.

klensy commented Jan 22, 2024

Mark-Simulacrum commented Jan 27, 2024

bors commented Jan 27, 2024

nnethercote commented Jan 30, 2024

matthiaskrgr commented Feb 5, 2024

klensy commented Feb 12, 2024

bors commented Feb 16, 2024

klensy commented Feb 17, 2024

Mark-Simulacrum commented Feb 17, 2024

bors commented Feb 17, 2024

bors commented Feb 17, 2024

bors commented Feb 17, 2024

rust-timer commented Feb 17, 2024

Overall result: ❌✅ regressions and improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

klensy commented Jan 16, 2024 •

edited

Loading