Revert "Add a proper with_no_queries to printing"
#121981
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6fb4ac6. Reverts rust-lang#121927 Fixes rust-lang#121974
rustbot
added
A-query-system
Zoxc
reviewed
Mar 4, 2024
| let description = if tcx.sess.verbose_internals() { | ||
| format!("{description} [{name:?}]") | ||
| } else { | ||
| description | ||
| }; | ||
| let span = if kind == dep_graph::dep_kinds::def_span { | ||
| let span = if kind == dep_graph::dep_kinds::def_span || with_no_queries() { |
There was a problem hiding this comment.
Would bringing only these last 2 changes back as with_reduced_queries() fix the issue?
There was a problem hiding this comment.
I opened #121993 for that. It fixes OOM for the test case we have.
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Mar 5, 2024
…compiler-errors Avoid using unnecessary queries when printing the query stack in panics This should fix rust-lang#121974. Alternative to rust-lang#121981.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 5, 2024
…compiler-errors Avoid using unnecessary queries when printing the query stack in panics This should fix rust-lang#121974. Alternative to rust-lang#121981.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 5, 2024
…compiler-errors Avoid using unnecessary queries when printing the query stack in panics This should fix rust-lang#121974. Alternative to rust-lang#121981.
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 5, 2024
Rollup merge of rust-lang#121993 - Zoxc:query-stack-panic-queries, r=compiler-errors Avoid using unnecessary queries when printing the query stack in panics This should fix rust-lang#121974. Alternative to rust-lang#121981.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 6fb4ac6.
Reverts #121927
Fixes #121974
r? @oli-obk
cc @Zoxc