Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove optionality from MoveData::base_local #124185

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Remove optionality from MoveData::base_local #124185

merged 1 commit into from
Apr 30, 2024

Conversation

beepster4096
Copy link
Contributor

This is an artifact from when Places could be based on statics and not just locals. Now, all move paths either are locals or have parents, so this doesn't need to return Option anymore.

@rustbot
Copy link
Collaborator

rustbot commented Apr 20, 2024

r? @pnkfelix

rustbot has assigned @pnkfelix.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 20, 2024
@pnkfelix
Copy link
Member

pnkfelix commented Apr 29, 2024 •
edited
Loading

@bors r+

(for those who are curious, the change to remove Static as one of the PlaceBase variants was in fd5aa32 as part of #67000 )

@bors
Copy link
Contributor

bors commented Apr 29, 2024

📌 Commit 1707346 has been approved by pnkfelix

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 29, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 29, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 29, 2024
@bors
Auto merge of rust-lang#124537 - matthiaskrgr:rollup-zjv9gu8, r=matth…
7823bf0 
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#124185 (Remove optionality from MoveData::base_local)
 - rust-lang#124488 (Add a note to the ArbitraryExpressionInPattern error)
 - rust-lang#124530 (Fix Fuchsia build broken by rust-lang#124210)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6ce9708 into rust-lang:master Apr 30, 2024
12 checks passed
@rustbot rustbot added this to the 1.80.0 milestone Apr 30, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 30, 2024
@rust-timer
Unrolled build for rust-lang#124185
a5ec5d4 
Rollup merge of rust-lang#124185 - beepster4096:move_data_base_local_infallible, r=pnkfelix

Remove optionality from MoveData::base_local

This is an artifact from when Places could be based on statics and not just locals. Now, all move paths either are locals or have parents, so this doesn't need to return Option anymore.
@bors
Copy link
Contributor

bors commented Apr 30, 2024

⌛ Testing commit 1707346 with merge 7823bf0...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pnkfelix pnkfelix

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.80.0
Development

Successfully merging this pull request may close these issues.
4 participants
@beepster4096 @rustbot @pnkfelix @bors