Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make early lints translatable #124417

Merged
merged 12 commits into from
May 21, 2024
Merged

Make early lints translatable #124417

merged 12 commits into from
May 21, 2024

Commits on May 21, 2024

  1. Implement IntoDiagArg for hir Namespace

    @Xiretza
    Xiretza committed May 21, 2024
    Configuration menu
    Copy the full SHA
    3b979ae View commit details
    Browse the repository at this point in the history

  2. Implement IntoDiagArg for RustcVersion

    @Xiretza
    Xiretza committed May 21, 2024
    Configuration menu
    Copy the full SHA
    56bca95 View commit details
    Browse the repository at this point in the history

  3. Add note_once/help_once to diagnostic derives

    @Xiretza
    Xiretza committed May 21, 2024
    Configuration menu
    Copy the full SHA
    eee14e9 View commit details
    Browse the repository at this point in the history

  4. Fix subdiagnostic-only enum variants not generating code

    @Xiretza
    Xiretza committed May 21, 2024
    Configuration menu
    Copy the full SHA
    36902fb View commit details
    Browse the repository at this point in the history

  5. Convert NAMED_ASM_LABELS lint to diag struct

    @Xiretza
    Xiretza committed May 21, 2024
    Configuration menu
    Copy the full SHA
    bac6b62 View commit details
    Browse the repository at this point in the history

  6. Convert unexpected_cfg_{name,value} to struct diagnostics

    @Xiretza
    Xiretza committed May 21, 2024
    Configuration menu
    Copy the full SHA
    2482f3c View commit details
    Browse the repository at this point in the history

  7. Generate lint diagnostic message from BuiltinLintDiag 

    Translation of the lint message happens when the actual diagnostic is
created, not when the lint is buffered. Generating the message from
BuiltinLintDiag ensures that all required data to construct the message
is preserved in the LintBuffer, eventually allowing the messages to be
moved to fluent.

Remove the `msg` field from BufferedEarlyLint, it is either generated
from the data in the BuiltinLintDiag or stored inside
BuiltinLintDiag::Normal.
    @Xiretza
    Xiretza committed May 21, 2024
    Configuration menu
    Copy the full SHA
    c227f35 View commit details
    Browse the repository at this point in the history

  8. Port DeprecatedMacro to diag structs

    @Xiretza
    Xiretza committed May 21, 2024
    Configuration menu
    Copy the full SHA
    41a20b4 View commit details
    Browse the repository at this point in the history

  9. Convert uses of BuiltinLintDiag::Normal to custom variants 

    This ensures all diagnostic messages are created at diagnostic emission
time, making them translatable.
    @Xiretza
    Xiretza committed May 21, 2024
    Configuration menu
    Copy the full SHA
    b7abf01 View commit details
    Browse the repository at this point in the history

  10. Make early lints translatable

    @Xiretza
    Xiretza committed May 21, 2024
    Configuration menu
    Copy the full SHA
    8004e6a View commit details
    Browse the repository at this point in the history

  11. Fix typo in deprecation lint message

    @Xiretza
    Xiretza committed May 21, 2024
    Configuration menu
    Copy the full SHA
    c4f6502 View commit details
    Browse the repository at this point in the history

  12. Rename buffer_lint_with_diagnostic to buffer_lint

    @Xiretza
    Xiretza committed May 21, 2024
    Configuration menu
    Copy the full SHA
    98dd6c7 View commit details
    Browse the repository at this point in the history