-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support to override lldb binary path for ./x test #124501
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
This PR modifies If appropriate, please update |
0aee267
to
d6b88a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are going to support this, we need to document it in config.example.toml
, just like any other option.
This PR modifies If appropriate, please update |
@rustbot review |
@bors r+ rollup |
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#124501 (add support to override lldb binary path for ./x test) - rust-lang#124573 (add a reference link to the comment of the "cc" and "cmake".) - rust-lang#124663 (Enable reusing CI Docker cache when running CI images locally) - rust-lang#124690 (Only consider ambiguous goals when finding best obligation for ambiguities) - rust-lang#124713 (Update Cargo specific diagnostics in check-cfg) - rust-lang#124717 (Implement `do_not_recommend` in the new solver) - rust-lang#124718 (Record impl args in the proof tree) - rust-lang#124720 (interpret: Drop: always evaluate place) - rust-lang#124721 (library/std: Fix build for NetBSD targets with 32-bit `c_long`) - rust-lang#124723 (Use correct Hermit links in The `rustc` Book) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#124501 - VladimirMakaev:add-lldb-to-config-toml, r=Mark-Simulacrum add support to override lldb binary path for ./x test When running debuginfo tests I couldn't set custom build of lldb. The `src/bootstrap/src/core/build_steps/test.rs` has "lldb" hardcoded. I ended up hacking `src/bootstrap/src/core/build_steps/test.rs` just to get the tests running the way I wanted. Then I've found out that we can override `gdb` under [build] section. This PR enables the same for `lldb`
When running debuginfo tests I couldn't set custom build of lldb. The
src/bootstrap/src/core/build_steps/test.rs
has "lldb" hardcoded. I ended up hackingsrc/bootstrap/src/core/build_steps/test.rs
just to get the tests running the way I wanted.Then I've found out that we can override
gdb
under [build] section. This PR enables the same forlldb