Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 4 pull requests #125324

Merged
merged 14 commits into from
May 20, 2024
Merged

Rollup of 4 pull requests #125324

merged 14 commits into from
May 20, 2024

Commits on May 19, 2024

  1. Use a single static for all default slice Arcs.

    Also adds debug_asserts in Drop for Weak/Arc that the shared static is not being "dropped"/"deallocated".
    zachs18 committed May 19, 2024
    Configuration menu
    Copy the full SHA
    e6396bc View commit details
    Browse the repository at this point in the history
  2. Fix stacked borrows violation

    zachs18 committed May 19, 2024
    Configuration menu
    Copy the full SHA
    2dacd70 View commit details
    Browse the repository at this point in the history
  3. fmt

    zachs18 committed May 19, 2024
    Configuration menu
    Copy the full SHA
    6fae171 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    58f8ed1 View commit details
    Browse the repository at this point in the history
  5. Fix typo in assert message

    zachs18 committed May 19, 2024
    Configuration menu
    Copy the full SHA
    3299823 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    91685c0 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    9dc073a View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Configuration menu
    Copy the full SHA
    dbfed2c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    090dbb1 View commit details
    Browse the repository at this point in the history
  3. Fix tests/debuginfo/strings-and-strs.

    It fails on my machine because it embeds pointer addresses in the
    expected output.
    
    This commit replaces the addresses with `0x[...]`.
    nnethercote committed May 20, 2024
    Configuration menu
    Copy the full SHA
    4654e87 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#125255 - compiler-errors:eval-ctxt-generic,…

    … r=lcnr
    
    Make `EvalCtxt` generic over `InferCtxtLike`
    
    ...but don't change any of the impls, yet! These can get uplifted as we add more methods to `InferCtxtLike`/`Interner` :3
    
    This is built on top of rust-lang#125230.
    
    r? lcnr
    matthiaskrgr authored May 20, 2024
    Configuration menu
    Copy the full SHA
    9911788 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#125283 - zachs18:arc-default-shared, r=dtolnay

    Use a single static for all default slice Arcs.
    
    Also adds debug_asserts in Drop for Weak/Arc that the shared static is not being "dropped"/"deallocated".
    
    As per rust-lang#124640 (review)
    
    r? dtolnay
    matthiaskrgr authored May 20, 2024
    Configuration menu
    Copy the full SHA
    d1da238 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#125300 - compiler-errors:dont-strip-inherit…

    …ed-viz, r=fmease
    
    rustdoc: Don't strip items with inherited visibility in `AliasedNonLocalStripper`
    
    Enum variants return `None` in `Item::visibility`, which fails the comparison to `Some(Visibility::Public)`. This means that all enums in type aliases are being stripped, leading to this in the `rustc_middle` docs:
    
    <img width="474" alt="image" src="https:/rust-lang/rust/assets/3674314/83704d94-a571-4c28-acbd-ca51c4efd46e">
    
    This regressed in rust-lang#124939 (comment).
    
    This switches the `AliasedNonLocalStripper` to not strip items with `None` as their visibility.
    matthiaskrgr authored May 20, 2024
    Configuration menu
    Copy the full SHA
    3a50315 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#125309 - nnethercote:fix-strings-and-strs, …

    …r=Mark-Simulacrum
    
    Fix `tests/debuginfo/strings-and-strs`.
    
    It fails on my machine because it embeds pointer addresses in the expected output.
    
    This commit replaces the addresses with `0x[...]`.
    
    r? ```@Mark-Simulacrum```
    matthiaskrgr authored May 20, 2024
    Configuration menu
    Copy the full SHA
    e45fd06 View commit details
    Browse the repository at this point in the history