-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 7 pull requests #125358
Rollup of 7 pull requests #125358
Commits on May 5, 2024
-
Document all Apple targets in rustc's platform support
- Fixed std support in top-level docs. - Added `*-apple-darwin` docs. - Added `i686-apple-darwin` docs. - Moved `aarch64-apple-ios-sim` to `*-apple-ios` and document all the iOS targets there. - Added `*-apple-ios-macabi` docs. - Add myself (madsmtm) as co-maintainer of most of these targets.
Configuration menu - View commit details
-
Copy full SHA for 0eb782d - Browse repository at this point
Copy the full SHA 0eb782dView commit details
Commits on May 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1d1981b - Browse repository at this point
Copy the full SHA 1d1981bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 579266a - Browse repository at this point
Copy the full SHA 579266aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ab0af8 - Browse repository at this point
Copy the full SHA 9ab0af8View commit details
Commits on May 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b8b6898 - Browse repository at this point
Copy the full SHA b8b6898View commit details
Commits on May 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b964b00 - Browse repository at this point
Copy the full SHA b964b00View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c30142 - Browse repository at this point
Copy the full SHA 5c30142View commit details -
Configuration menu - View commit details
-
Copy full SHA for f0b8da4 - Browse repository at this point
Copy the full SHA f0b8da4View commit details -
Configuration menu - View commit details
-
Copy full SHA for abdaed2 - Browse repository at this point
Copy the full SHA abdaed2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d0b75f - Browse repository at this point
Copy the full SHA 9d0b75fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c43e54 - Browse repository at this point
Copy the full SHA 8c43e54View commit details -
Use
_NSGetEnviron
instead ofenviron
on iOS/tvOS/watchOS/visionOSThis should be slightly more correct, and matches the implementation in other programming languages: - [Python's `os.environ`](https:/python/cpython/blob/v3.12.3/Modules/posixmodule.c#L1562-L1566). - [Swift's `Darwin.environ`](https:/apple/swift-corelibs-foundation/blob/swift-5.10-RELEASE/CoreFoundation/Base.subproj/CFPlatform.c#L1811-L1812), though that library is bundled on the system, so they can change it if they want. - [Dart/Flutter](https:/dart-lang/sdk/blob/3.4.0/runtime/bin/platform_macos.cc#L205-L234), doesn't support environment variables on iOS. - Node seems to not be entirely consistent with it: - [`process.c`](https:/nodejs/node/blob/v22.1.0/deps/uv/src/unix/process.c#L38). - [`unix/core.c`](https:/nodejs/node/blob/v22.1.0/deps/uv/src/unix/core.c#L59). - [.NET/Xamarin](https:/dotnet/runtime/blob/v8.0.5/src/native/libs/configure.cmake#L1099-L1106). - [OpenJDK](https:/openjdk/jdk/blob/jdk-23%2B22/src/java.base/unix/native/libjava/ProcessEnvironment_md.c#L31-L33).
Configuration menu - View commit details
-
Copy full SHA for 6016bad - Browse repository at this point
Copy the full SHA 6016badView commit details -
Use
_NSGetArgc
/_NSGetArgv
on iOS/tvOS/watchOS/visionOSIf we're comfortable using `_NSGetEnviron` from `crt_externs.h`, there shouldn't be an issue with using these either, and then we can merge with the macOS implementation. This also fixes two test cases on Mac Catalyst: - `tests/ui/command/command-argv0.rs`, maybe because `[[NSProcessInfo processInfo] arguments]` somehow converts the name of the first argument? - `tests/ui/env-funky-keys.rs` since we no longer link to Foundation.
Configuration menu - View commit details
-
Copy full SHA for 8f18e4f - Browse repository at this point
Copy the full SHA 8f18e4fView commit details
Commits on May 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1914c72 - Browse repository at this point
Copy the full SHA 1914c72View commit details -
Configuration menu - View commit details
-
Copy full SHA for abd5d0e - Browse repository at this point
Copy the full SHA abd5d0eView commit details
Commits on May 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1185a64 - Browse repository at this point
Copy the full SHA 1185a64View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9557b90 - Browse repository at this point
Copy the full SHA 9557b90View commit details -
Configuration menu - View commit details
-
Copy full SHA for 213351a - Browse repository at this point
Copy the full SHA 213351aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 38ad851 - Browse repository at this point
Copy the full SHA 38ad851View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d23a71 - Browse repository at this point
Copy the full SHA 0d23a71View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd71c71 - Browse repository at this point
Copy the full SHA bd71c71View commit details -
Configuration menu - View commit details
-
Copy full SHA for f6cf103 - Browse repository at this point
Copy the full SHA f6cf103View commit details
Commits on May 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 95c47d3 - Browse repository at this point
Copy the full SHA 95c47d3View commit details -
And remove an unnecessary `feature(try_blocks)`.
Configuration menu - View commit details
-
Copy full SHA for eb10eb2 - Browse repository at this point
Copy the full SHA eb10eb2View commit details -
Configuration menu - View commit details
-
Copy full SHA for d8ea468 - Browse repository at this point
Copy the full SHA d8ea468View commit details -
Configuration menu - View commit details
-
Copy full SHA for ce22232 - Browse repository at this point
Copy the full SHA ce22232View commit details -
The comment was originally in `src/librustc_mir/lib.rs`, but now that it's in `compiler/rustc_const_eval/src/lib.rs` it's no longer appropriate.
Configuration menu - View commit details
-
Copy full SHA for c1d5b6a - Browse repository at this point
Copy the full SHA c1d5b6aView commit details -
Configuration menu - View commit details
-
Copy full SHA for ac847b2 - Browse repository at this point
Copy the full SHA ac847b2View commit details -
As is already done in several other crates, such as `rustc_errors`.
Configuration menu - View commit details
-
Copy full SHA for 3ac816a - Browse repository at this point
Copy the full SHA 3ac816aView commit details -
Rollup merge of rust-lang#124570 - nnethercote:misc-cleanups, r=micha…
…elwoerister Miscellaneous cleanups A mix of small cleanups made while looking at various things. r? `@wesleywiser`
Configuration menu - View commit details
-
Copy full SHA for df59800 - Browse repository at this point
Copy the full SHA df59800View commit details -
Rollup merge of rust-lang#124772 - madsmtm:apple-platform-support-doc…
…s, r=oli-obk Refactor documentation for Apple targets Refactor the documentation for Apple targets in `rustc`'s platform support page to make it clear what the supported OS version is and which environment variables are being read (`*_DEPLOYMENT_TARGET` and `SDKROOT`). This fixes rust-lang#124215. Note that I've expanded the `aarch64-apple-ios-sim` maintainers `@badboy` and `@deg4uss3r` to include being maintainer of all `*-apple-ios-*` targets. If you do not wish to be so, please state that, then I'll explicitly note that in the docs. Additionally, I've added myself as co-maintainer of most of these targets. r? `@thomcc` I think the documentation you've previously written on tvOS is great, have mostly modified it to have a more consistent formatting with the rest of the Apple target. I recognize that there's quite a few changes here, feel free to ask about any of them! --- CC `@simlay` `@Nilstrieb` `@rustbot` label O-apple
Configuration menu - View commit details
-
Copy full SHA for 4a4883b - Browse repository at this point
Copy the full SHA 4a4883bView commit details -
Rollup merge of rust-lang#125011 - diondokter:opt-for-size, r=Amanieu…
…,kobzol Add opt-for-size core lib feature flag Adds a feature flag to the core library that enables the possibility to have smaller implementations for certain algorithms. So far, the core lib has traded performance for binary size. This is likely what most people want since they have big simd-capable machines. However, people on small machines, like embedded devices, don't enjoy the potential speedup of the bigger algorithms, but do have to pay for them. These microcontrollers often only have 16-1024kB of flash memory. This PR is the result of some talks with project members like `@Amanieu` at RustNL. There are some open questions of how this is eventually stabilized, but it's a similar question as with the existing `panic_immediate_abort` feature. Speaking as someone from the embedded side, we'd rather have this unstable for a while as opposed to not having it at all. In the meantime we can try to use it and also add additional PRs to the core lib that uses the feature flag in areas where we find benefit. Open questions from my side: - Is this a good feature name? - `panic_immediate_abort` is fairly verbose, so I went with something equally verbose - It's easy to refactor later - I've added the feature to `std` and `alloc` as well as they might benefit too. Do we agree? - I expect these to get less usage out of the flag since most size-constraint projects don't use these libraries often.
Configuration menu - View commit details
-
Copy full SHA for 4abf179 - Browse repository at this point
Copy the full SHA 4abf179View commit details -
Rollup merge of rust-lang#125218 - Oneirical:easy-test-the-third, r=j…
…ieyouxu Migrate `run-make/no-intermediate-extras` to new `rmake.rs` Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html).
Configuration menu - View commit details
-
Copy full SHA for 7ef533b - Browse repository at this point
Copy the full SHA 7ef533bView commit details -
Rollup merge of rust-lang#125225 - madsmtm:ios-crt_externs.h, r=worki…
…ngjubilee Use functions from `crt_externs.h` on iOS/tvOS/watchOS/visionOS Use `_NSGetEnviron`, `_NSGetArgc` and `_NSGetArgv` on iOS/tvOS/watchOS/visionOS, see each commit and the code comments for details. This allows us to unify more code with the macOS implementation, as well as avoiding linking to the `Foundation` framework (which is good for startup performance). The biggest problem with doing this would be if it lead to App Store rejections. After doing a bunch of research on this, while [it did happen once in 2009](https://blog.unity.com/engine-platform/unity-app-store-submissions-problem-solved), I find it fairly unlikely to happen nowadays, especially considering that Apple has later _added_ `crt_externs.h` to the iOS/tvOS/watchOS/visionOS SDKs, strongly signifying the functions therein is indeed supported on those platforms (even though they lack an availability attribute). That we've been overly cautious here has also been noted by `@thomcc` in rust-lang#117910 (comment). r? `@workingjubilee` `@rustbot` label O-apple
Configuration menu - View commit details
-
Copy full SHA for a8ee8d5 - Browse repository at this point
Copy the full SHA a8ee8d5View commit details -
Rollup merge of rust-lang#125266 - workingjubilee:stream-plastic-love…
…, r=RalfJung,nikic compiler: add simd_ctpop intrinsic Fairly straightforward addition. cc `@rust-lang/opsem` new (extremely boring) intrinsic
Configuration menu - View commit details
-
Copy full SHA for fd975f7 - Browse repository at this point
Copy the full SHA fd975f7View commit details -
Rollup merge of rust-lang#125348 - tbu-:pr_doc_path_absolute, r=jhpratt
Small fixes to `std::path::absolute` docs
Configuration menu - View commit details
-
Copy full SHA for e6e05d5 - Browse repository at this point
Copy the full SHA e6e05d5View commit details