Make lint: lint_dropping_references lint_forgetting_copy_types lint_forgetting_references give suggestion if possible.

[surechen]

This is a follow-up PR of #125433. When it's merged, I want change lint dropping_copy_types to use the same Subdiagnostic struct UseLetUnderscoreIgnoreSuggestion which is added in this PR.

Hi, Thank you(@Urgau ) again for your help in the previous PR. If your time permits, please also take a look at this one.

r? compiler

[rustbot]

Failed to set assignee to Urgau: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

[bors]

☔ The latest upstream changes (presumably #125433) made this pull request unmergeable. Please resolve the merge conflicts.

[Urgau]

Looks go to me. Could you rebase on top of #125433.

@rustbot author
r? Urgau

[Urgau]

@bors r+

[bors]

📌 Commit 9d1ed80 has been approved by Urgau

It is now in the queue for this repository.

[bors]

⌛ Testing commit 9d1ed80 with merge a83f933...

[bors]

☀️ Test successful - checks-actions
Approved by: Urgau
Pushing a83f933 to master...

[rust-timer]

Finished benchmarking commit (a83f933): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.4%	[-0.4%, -0.3%]	3
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 0.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.7%	[2.7%, 2.7%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.7%	[-2.7%, -2.7%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.0%	[-2.7%, 2.7%]	2

Cycles

Results (primary 2.7%, secondary 3.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.7%	[2.3%, 3.0%]	4
Regressions ❌ (secondary)	3.0%	[2.2%, 3.8%]	12
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.7%	[2.3%, 3.0%]	4

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 667.137s -> 667.715s (0.09%)
Artifact size: 318.87 MiB -> 318.83 MiB (-0.01%)