Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #126297

Closed
wants to merge 15 commits into from
Closed

Commits on Apr 2, 2024

  1. Configuration menu
    Copy the full SHA
    8e91a51 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. Add "safety" comment

    mgeier committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    22319bf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4df1303 View commit details
    Browse the repository at this point in the history
  3. Add missing .into_iter()

    mgeier committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    30b676c View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. Configuration menu
    Copy the full SHA
    79dd1ca View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. Configuration menu
    Copy the full SHA
    bfb7757 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2024

  1. Configuration menu
    Copy the full SHA
    1462f3d View commit details
    Browse the repository at this point in the history
  2. Simplify [T; N]::try_map signature

    People keep making fun of this signature for being so gnarly.
    Associated type bounds lend it a much simpler scribbling.
    ChangeOutputType can also come along for the ride.
    workingjubilee committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    d695544 View commit details
    Browse the repository at this point in the history
  3. Make issue-122805.rs big endian compatible

    Instead of not generating the function at all on big endian (which
    makes the CHECK lines fail), instead use to_le() on big endian,
    so that we essentially perform a bswap for both endiannesses.
    nikic committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    26fa5c2 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. Rollup merge of rust-lang#123374 - mgeier:doc-slice-from-raw-parts, r…

    …=scottmcm
    
    DOC: Add FFI example for slice::from_raw_parts()
    
    For some discussion, see https://users.rust-lang.org/t/missing-guidance-on-converting-ffi-ptr-length-to-slice/106048
    
    See also rust-lang#120608.
    jhpratt authored Jun 12, 2024
    Configuration menu
    Copy the full SHA
    c8c16ff View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#126127 - Alexendoo:other-trait-diag, r=pnkf…

    …elix
    
    Spell out other trait diagnostic
    
    I recently saw somebody confused about the diagnostic thinking it was suggesting to add an `as` cast. This change is longer but I think it's clearer
    jhpratt authored Jun 12, 2024
    Configuration menu
    Copy the full SHA
    2ab4e49 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#126228 - BoxyUwU:nested_repeat_expr_generic…

    …s, r=compiler-errors
    
    Provide correct parent for nested anon const
    
    Fixes rust-lang#126147
    
    99% of this PR is just comments explaining what the issue is.
    
    `tcx.parent(` and `hir().get_parent_item(` give different results as the hir owner for all the hir of anon consts is the enclosing function. I didn't attempt to change that as being a hir owner requires a `DefId` and long term we want to stop creating anon consts' `DefId`s before hir ty lowering.
    
    So i just opted to change `generics_of` to use `tcx.parent` to get the parent for `AnonConst`'s. I'm not entirely sure about this being what we want, it does seem weird that we have two ways of getting the parent of an `AnonConst` and they both give different results.
    
    Alternatively we could just go ahead and make `const_evaluatable_unchecked` a hard error and stop providing generics to repeat exprs. Then this isn't an issue. (The FCW has been around for almost 4 years now)
    
    r? `@compiler-errors`
    jhpratt authored Jun 12, 2024
    Configuration menu
    Copy the full SHA
    a18c188 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#126249 - workingjubilee:simplify-try-map-si…

    …gnature, r=scottmcm
    
    Simplify `[T; N]::try_map` signature
    
    People keep making fun of this signature for being so gnarly.
    Associated type bounds admit a much simpler scribbling.
    
    r? `@scottmcm`
    jhpratt authored Jun 12, 2024
    Configuration menu
    Copy the full SHA
    98d8cc7 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#126256 - ferrocene:lw-target-subst, r=alber…

    …tlarsan68
    
    Add {{target}} substitution to compiletest
    
    In ferrocene we have ui tests testing the cli interface of the compiler, one of which tests the `--target` flag. To be able to run this on all targets we require a way to specify a valid target in the `compile-flags` directive that is target independent, as otherwise we can only run the test against the one target we choose to supply in the flags. See https:/ferrocene/ferrocene/blob/383cbc80f4e85859a4055f121f15dac329908346/tests/ui/ferrocene/compiler-arguments/target/target.rs
    
    We figured the project might be able to make use of this substitution as well in the future.
    
    try-job: dist-x86_64-msvc
    jhpratt authored Jun 12, 2024
    Configuration menu
    Copy the full SHA
    a927b66 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#126263 - nikic:s390x-codegen-test-fix, r=ji…

    …eyouxu
    
    Make issue-122805.rs big endian compatible
    
    Instead of not generating the function at all on big endian (which makes the CHECK lines fail), instead use to_le() on big endian, so that we essentially perform a bswap for both endiannesses.
    jhpratt authored Jun 12, 2024
    Configuration menu
    Copy the full SHA
    8732f19 View commit details
    Browse the repository at this point in the history