Rewrite and rename issue-14698. issue-33329 and issue-107094 run-make tests to rmake or ui

src/tools/tidy/src/allowed_run_make_makefiles.txt

@@ -27,10 +27,7 @@ run-make/foreign-rust-exceptions/Makefile
 run-make/incr-add-rust-src-component/Makefile
 run-make/incr-foreign-head-span/Makefile
 run-make/interdependent-c-libraries/Makefile
-run-make/issue-107094/Makefile
-run-make/issue-14698/Makefile
 run-make/issue-15460/Makefile
-run-make/issue-33329/Makefile
 run-make/issue-35164/Makefile
 run-make/issue-36710/Makefile
 run-make/issue-47551/Makefile

tests/run-make/invalid-tmpdir-env-var/rmake.rs

@@ -0,0 +1,20 @@
+// When the TMP (on Windows) or TMPDIR (on Unix) variable is set to an invalid
+// or non-existing directory, this used to cause an internal compiler error (ICE). After the
+// addition of proper error handling in #28430, this test checks that the expected message is
+// printed.
+// See https:/rust-lang/rust/issues/14698
+
+use run_make_support::{is_windows, rustc};
+
+// NOTE: This is not a UI test despite its simplicity, as the error message contains a path
+// with some variability that is difficult to normalize
+
+fn main() {
+ let mut rustc = rustc();
+ if is_windows() {
+ rustc.env("TMP", "fake");
+ } else {
+ rustc.env("TMPDIR", "fake");
+ }
+ rustc.input("foo.rs").run_fail().assert_stderr_contains("couldn't create a temp dir");
+}

tests/run-make/version-verbose-commit-hash/rmake.rs

@@ -0,0 +1,20 @@
+// `--version --verbose` should display the git-commit hashes of rustc and rustdoc, but this
+// functionality was lost due to #104184. After this feature was returned by #109981, this
+// test ensures it will not be broken again.
+// See https:/rust-lang/rust/issues/107094
+
+//@ needs-git-hash
+
+use run_make_support::{bare_rustc, bare_rustdoc, regex};
+
+fn main() {
+ let out_rustc =
+ bare_rustc().arg("--version").arg("--verbose").run().stdout_utf8().to_lowercase();
+ let out_rustdoc =
+ bare_rustdoc().arg("--version").arg("--verbose").run().stdout_utf8().to_lowercase();
+ let re =
+ regex::Regex::new(r#"commit-hash: [0-9a-f]{40}\ncommit-date: [0-9]{4}-[0-9]{2}-[0-9]{2}"#)
+ .unwrap();
+ assert!(re.is_match(&out_rustc));
+ assert!(re.is_match(&out_rustdoc));
+}

tests/ui/errors/wrong-target-spec.rs

@@ -0,0 +1,8 @@
+// The attentive may note the underscores in the target triple, making it invalid. This test
+// checks that such invalid target specs are rejected by the compiler.
+// See https:/rust-lang/rust/issues/33329
+
+//@ needs-llvm-components: x86
+//@ compile-flags: --target x86_64_unknown-linux-musl
+
+fn main() {}

tests/ui/errors/wrong-target-spec.stderr

@@ -0,0 +1,2 @@
+error: Error loading target specification: Could not find specification for target "x86_64_unknown-linux-musl". Run `rustc --print target-list` for a list of built-in targets
+